Bug 191219

Summary:

Update buildbot dashboard after Windows 7/10 updates

Product:

WebKit

Reporter:

Lucas Forschler <lforschler>

Component:

Tools / Tests

Assignee:

Ryan Haddad <ryanhaddad>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, commit-queue, lforschler, ryanhaddad, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Safari 11

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
v1 patch	none
Proposed solution with AppleWin10 labels	none
Screenshot of option 2	none
Patch	none

Lucas Forschler

Reported 2018-11-02 16:47:55 PDT

We restructured bot configs for windows, so we should update the dashboard to reflect that.

Attachments
v1 patch (3.16 KB, patch) 2018-11-02 16:50 PDT, Lucas Forschler	no flags	Details Formatted Diff Diff
Proposed solution with AppleWin10 labels (891.05 KB, image/png) 2018-11-02 17:23 PDT, Ryan Haddad	no flags	Details
Screenshot of option 2 (1.08 MB, image/png) 2018-11-05 16:32 PST, Ryan Haddad	no flags	Details
Patch (10.09 KB, patch) 2018-11-15 17:31 PST, Ryan Haddad	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Lucas Forschler

Comment 1 2018-11-02 16:50:54 PDT

Created attachment 353745 [details] v1 patch

Ryan Haddad

Comment 2 2018-11-02 16:59:42 PDT

Comment on attachment 353745 [details] v1 patch View in context: https://bugs.webkit.org/attachment.cgi?id=353745&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:66 > + "Apple Win 10 Debug (Build)": {platform: Dashboard.Platform.Windows10, debug: true, builder: true, architecture: Buildbot.BuildArchitecture.ThirtyTwoBit}, Using Dashboard.Platform.Windows10 will place these in the same section as the WinCairo bots, so I don't think we should do this.

Ryan Haddad

Comment 3 2018-11-02 17:23:18 PDT

Created attachment 353748 [details] Proposed solution with AppleWin10 labels Here is one potential solution that adds AppleWin10 labels to the new queues. I can upload the patch if we want to do this.

Ryan Haddad

Comment 4 2018-11-05 16:32:18 PST

Created attachment 353922 [details] Screenshot of option 2 Here is another option that adds labels to the Windows queues.

Ryan Haddad

Comment 5 2018-11-15 17:31:24 PST

Created attachment 355003 [details] Patch

Ryan Haddad

Comment 6 2018-11-15 17:32:54 PST

(In reply to Ryan Haddad from comment #5) > Created attachment 355003 [details] > Patch This is okay to land as is, but the CSS should probably be updated for the queue names on the dashboard. As seen in the screenshot, they cling to the bottom of the row.

WebKit Commit Bot

Comment 7 2018-11-16 17:10:58 PST

Comment on attachment 355003 [details] Patch Clearing flags on attachment: 355003 Committed r238328: <https://trac.webkit.org/changeset/238328>

WebKit Commit Bot

Comment 8 2018-11-16 17:11:00 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 9 2018-11-16 17:11:27 PST

<rdar://problem/46144574>

Note You need to log in before you can comment on or make changes to this bug.