Bug 191178

Summary: Replace CommonRandom SPI with API
Product: WebKit Reporter: Jiewen Tan <jiewen_tan>
Component: WebKit Misc.Assignee: Jiewen Tan <jiewen_tan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, mitz, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Jiewen Tan
Reported 2018-11-01 17:05:54 PDT
Replace CommonRandom SPI with API as the SPI is out dated.
Attachments
Patch (12.73 KB, patch)
2018-11-01 17:17 PDT, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Patch (12.82 KB, patch)
2018-11-01 17:31 PDT, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jiewen Tan
Comment 1 2018-11-01 17:06:55 PDT
<rdar://problem/45722391>
Jiewen Tan
Comment 2 2018-11-01 17:17:07 PDT
Created attachment 353666 [details] Patch
Jiewen Tan
Comment 3 2018-11-01 17:25:35 PDT
Sad that the header before macOS 10.14 doesn't include: #include <CommonCrypto/CommonCryptoError.h>. Will modify the patch to include the additional header.
Jiewen Tan
Comment 4 2018-11-01 17:31:29 PDT
Created attachment 353668 [details] Patch
Brent Fulgham
Comment 5 2018-11-01 18:26:45 PDT
Comment on attachment 353668 [details] Patch Oh great! API is always >> SPI!
Jiewen Tan
Comment 6 2018-11-01 23:10:04 PDT
Comment on attachment 353668 [details] Patch Thanks Brent for r+ the patch.
WebKit Commit Bot
Comment 7 2018-11-01 23:36:05 PDT
Comment on attachment 353668 [details] Patch Clearing flags on attachment: 353668 Committed r237721: <https://trac.webkit.org/changeset/237721>
WebKit Commit Bot
Comment 8 2018-11-01 23:36:07 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.