Bug 191178

Summary: Replace CommonRandom SPI with API
Product: WebKit Reporter: Jiewen Tan <jiewen_tan>
Component: WebKit Misc.Assignee: Jiewen Tan <jiewen_tan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, mitz, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Jiewen Tan 2018-11-01 17:05:54 PDT 
Replace CommonRandom SPI with API as the SPI is out dated.
Comment 1 Jiewen Tan 2018-11-01 17:06:55 PDT 
<rdar://problem/45722391>
Comment 2 Jiewen Tan 2018-11-01 17:17:07 PDT 
Created attachment 353666 [details]
Patch
Comment 3 Jiewen Tan 2018-11-01 17:25:35 PDT 
Sad that the header before macOS 10.14 doesn't include:
#include <CommonCrypto/CommonCryptoError.h>.

Will modify the patch to include the additional header.
Comment 4 Jiewen Tan 2018-11-01 17:31:29 PDT 
Created attachment 353668 [details]
Patch
Comment 5 Brent Fulgham 2018-11-01 18:26:45 PDT 
Comment on attachment 353668 [details]
Patch

Oh great! API is always >> SPI!
Comment 6 Jiewen Tan 2018-11-01 23:10:04 PDT 
Comment on attachment 353668 [details]
Patch

Thanks Brent for r+ the patch.
Comment 7 WebKit Commit Bot 2018-11-01 23:36:05 PDT 
Comment on attachment 353668 [details]
Patch

Clearing flags on attachment: 353668

Committed r237721: <https://trac.webkit.org/changeset/237721>
Comment 8 WebKit Commit Bot 2018-11-01 23:36:07 PDT 
All reviewed patches have been landed.  Closing bug.