Bug 191139

Summary:

Resync html/browsers/history/the-location-interface web platform tests from upstream

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Tools / Tests

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, dewei_zhu, ews-watchlist, lforschler, rniwa, ryanhaddad, tsavell, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

191060

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews103 for mac-sierra	none
Archive of layout-test-results from ews116 for mac-sierra	none
Patch	none

Chris Dumez

Reported 2018-10-31 16:31:30 PDT

Resync html/browsers/history/the-location-interface web platform tests from upstream.

Attachments
Patch (32.80 KB, patch) 2018-10-31 16:45 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-sierra (2.52 MB, application/zip) 2018-10-31 17:59 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews116 for mac-sierra (3.32 MB, application/zip) 2018-10-31 19:08 PDT, EWS Watchlist	no flags	Details
Patch (34.12 KB, patch) 2018-11-01 08:49 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2018-10-31 16:45:31 PDT

Created attachment 353556 [details] Patch

EWS Watchlist

Comment 2 2018-10-31 17:59:38 PDT

Comment on attachment 353556 [details] Patch Attachment 353556 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9803835 New failing tests: imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/assign_after_load.html imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/assign_before_load.html

EWS Watchlist

Comment 3 2018-10-31 17:59:39 PDT

Created attachment 353564 [details] Archive of layout-test-results from ews103 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 4 2018-10-31 19:08:00 PDT

Comment on attachment 353556 [details] Patch Attachment 353556 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9804258 New failing tests: imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/assign_after_load.html imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/assign_before_load.html

EWS Watchlist

Comment 5 2018-10-31 19:08:01 PDT

Created attachment 353571 [details] Archive of layout-test-results from ews116 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-sierra Platform: Mac OS X 10.12.6

Chris Dumez

Comment 6 2018-11-01 08:49:42 PDT

Created attachment 353602 [details] Patch

Chris Dumez

Comment 7 2018-11-01 11:58:37 PDT

Comment on attachment 353602 [details] Patch Clearing flags on attachment: 353602 Committed r237693: <https://trac.webkit.org/changeset/237693>

Chris Dumez

Comment 8 2018-11-01 11:58:39 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 9 2018-11-01 11:59:24 PDT

<rdar://problem/45737202>

Truitt Savell

Comment 10 2018-11-01 13:43:26 PDT

These two newly imported tests: imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/assign_after_load.html imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/assign_before_load.html Are failing on release WK1 so far. History: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2Fhtml%2Fbrowsers%2Fhistory%2Fthe-location-interface%2Fassign_before_load.html%20imported%2Fw3c%2Fweb-platform-tests%2Fhtml%2Fbrowsers%2Fhistory%2Fthe-location-interface%2Fassign_after_load.html Diff: --- /Volumes/Data/slave/sierra-release-tests-wk1/build/layout-test-results/imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/assign_after_load-expected.txt +++ /Volumes/Data/slave/sierra-release-tests-wk1/build/layout-test-results/imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/assign_after_load-actual.txt @@ -1,3 +1,3 @@ -FAIL Assignment to location after document is completely loaded assert_equals: expected 3 but got 2 +FAIL Assignment to location after document is completely loaded assert_equals: expected 102 but got 100 Diff: --- /Volumes/Data/slave/sierra-release-tests-wk1/build/layout-test-results/imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/assign_before_load-expected.txt +++ /Volumes/Data/slave/sierra-release-tests-wk1/build/layout-test-results/imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/assign_before_load-actual.txt @@ -1,3 +1,3 @@ -FAIL Assignment to location before document is completely loaded assert_equals: expected 4 but got 3 +FAIL Assignment to location before document is completely loaded assert_equals: expected 101 but got 100

Chris Dumez

Comment 11 2018-11-01 13:44:20 PDT

(In reply to Truitt Savell from comment #10) > These two newly imported tests: > > imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/ > assign_after_load.html > imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/ > assign_before_load.html > > Are failing on release WK1 so far. > > History: > https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard. > html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform- > tests%2Fhtml%2Fbrowsers%2Fhistory%2Fthe-location- > interface%2Fassign_before_load.html%20imported%2Fw3c%2Fweb-platform- > tests%2Fhtml%2Fbrowsers%2Fhistory%2Fthe-location- > interface%2Fassign_after_load.html > > > Diff: > --- > /Volumes/Data/slave/sierra-release-tests-wk1/build/layout-test-results/ > imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/ > assign_after_load-expected.txt > +++ > /Volumes/Data/slave/sierra-release-tests-wk1/build/layout-test-results/ > imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/ > assign_after_load-actual.txt > @@ -1,3 +1,3 @@ > > -FAIL Assignment to location after document is completely loaded > assert_equals: expected 3 but got 2 > +FAIL Assignment to location after document is completely loaded > assert_equals: expected 102 but got 100 > > > Diff: > --- > /Volumes/Data/slave/sierra-release-tests-wk1/build/layout-test-results/ > imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/ > assign_before_load-expected.txt > +++ > /Volumes/Data/slave/sierra-release-tests-wk1/build/layout-test-results/ > imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/ > assign_before_load-actual.txt > @@ -1,3 +1,3 @@ > > -FAIL Assignment to location before document is completely loaded > assert_equals: expected 4 but got 3 > +FAIL Assignment to location before document is completely loaded > assert_equals: expected 101 but got 100 Bubbles were green so I suspect flakiness. Will deal with this shortly.

Chris Dumez

Comment 12 2018-11-01 13:47:45 PDT

(In reply to Chris Dumez from comment #11) > (In reply to Truitt Savell from comment #10) > > These two newly imported tests: > > > > imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/ > > assign_after_load.html > > imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/ > > assign_before_load.html > > > > Are failing on release WK1 so far. > > > > History: > > https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard. > > html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform- > > tests%2Fhtml%2Fbrowsers%2Fhistory%2Fthe-location- > > interface%2Fassign_before_load.html%20imported%2Fw3c%2Fweb-platform- > > tests%2Fhtml%2Fbrowsers%2Fhistory%2Fthe-location- > > interface%2Fassign_after_load.html > > > > > > Diff: > > --- > > /Volumes/Data/slave/sierra-release-tests-wk1/build/layout-test-results/ > > imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/ > > assign_after_load-expected.txt > > +++ > > /Volumes/Data/slave/sierra-release-tests-wk1/build/layout-test-results/ > > imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/ > > assign_after_load-actual.txt > > @@ -1,3 +1,3 @@ > > > > -FAIL Assignment to location after document is completely loaded > > assert_equals: expected 3 but got 2 > > +FAIL Assignment to location after document is completely loaded > > assert_equals: expected 102 but got 100 > > > > > > Diff: > > --- > > /Volumes/Data/slave/sierra-release-tests-wk1/build/layout-test-results/ > > imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/ > > assign_before_load-expected.txt > > +++ > > /Volumes/Data/slave/sierra-release-tests-wk1/build/layout-test-results/ > > imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/ > > assign_before_load-actual.txt > > @@ -1,3 +1,3 @@ > > > > -FAIL Assignment to location before document is completely loaded > > assert_equals: expected 4 but got 3 > > +FAIL Assignment to location before document is completely loaded > > assert_equals: expected 101 but got 100 > > Bubbles were green so I suspect flakiness. Will deal with this shortly. https://trac.webkit.org/r237698

Note You need to log in before you can comment on or make changes to this bug.