Bug 191124

Summary: Cleanup: Extraneous platform guarding of -_setUpSQLiteDatabaseTrackerClient
Product: WebKit Reporter: Daniel Bates <dbates>
Component: WebKit2Assignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Daniel Bates
Reported 2018-10-31 11:30:07 PDT
Currently we have a PLATFORM(IOS_FAMILY) guard around the call to -_setUpSQLiteDatabaseTrackerClient and we have PLATFORM(IOS_FAMILY) guards in the implementation of that message. It seems unnecessary to have both.
Attachments
Patch (1.66 KB, patch)
2018-10-31 11:35 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2018-10-31 11:35:31 PDT
Created attachment 353512 [details] Patch Let me know if it is preferred to keep the guards around the function call and move the guards in the implementation to be surrounding the implementation. With the guards removed from the call site, I would hope that the compiler is smart enough to realize that the called function is empty and just elide the function call. Maybe this is not true (I haven't looked at the binary) or maybe we have compiler warnings enabled to catch empty functions (I also haven't looked)?
Daniel Bates
Comment 2 2018-11-01 16:22:28 PDT
Comment on attachment 353512 [details] Patch Clearing flags on attachment: 353512 Committed r237704: <https://trac.webkit.org/changeset/237704>
Daniel Bates
Comment 3 2018-11-01 16:22:29 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2018-11-01 16:23:22 PDT
<rdar://problem/45746625>
Note You need to log in before you can comment on or make changes to this bug.