Bug 191118

Summary: [style] Exclude style check for auto generated files.
Product: WebKit Reporter: Basuke Suzuki <basuke>
Component: Tools / TestsAssignee: Basuke Suzuki <basuke>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ap, basuke, bfulgham, commit-queue, darin, dbates, ddkilzer, eric.carlson, ews-watchlist, glenn, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
FIX
none
Archive of layout-test-results from ews125 for ios-simulator-wk2 none

Basuke Suzuki
Reported 2018-10-31 10:33:32 PDT
Some files checked in to the repository are generated by other tools. In this patch, "MiniBrowserLibResource.h" is the file generated and managed by resource editor of VisualStudio. There's no need to check these files because it's not practical to fix the style errors or it's hard to maintain those fixes.
Attachments
FIX (2.47 KB, patch)
2018-10-31 10:52 PDT, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews125 for ios-simulator-wk2 (2.35 MB, application/zip)
2018-10-31 12:53 PDT, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Basuke Suzuki
Comment 1 2018-10-31 10:52:02 PDT
Created attachment 353505 [details] FIX
Basuke Suzuki
Comment 2 2018-10-31 10:57:40 PDT
https://bugs.webkit.org/show_bug.cgi?id=189053#c25
EWS Watchlist
Comment 3 2018-10-31 12:53:01 PDT
Comment on attachment 353505 [details] FIX Attachment 353505 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9797777 New failing tests: http/wpt/mediarecorder/MediaRecorder-mock-dataavailable.html
EWS Watchlist
Comment 4 2018-10-31 12:53:03 PDT
Created attachment 353520 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Basuke Suzuki
Comment 5 2018-11-02 11:48:06 PDT
Can anybody review this?
Eric Carlson
Comment 6 2018-11-02 19:32:45 PDT
(In reply to Basuke Suzuki from comment #5) > Can anybody review this? r=me. Thanks, and apologies for the delay in reviewing it.
Basuke Suzuki
Comment 7 2018-11-05 11:37:49 PST
Comment on attachment 353505 [details] FIX Thanks, Eric.
WebKit Commit Bot
Comment 8 2018-11-05 12:03:29 PST
Comment on attachment 353505 [details] FIX Clearing flags on attachment: 353505 Committed r237826: <https://trac.webkit.org/changeset/237826>
WebKit Commit Bot
Comment 9 2018-11-05 12:03:31 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2018-11-05 12:04:54 PST
<rdar://problem/45815353>
Note You need to log in before you can comment on or make changes to this bug.