Bug 191060

Summary: Location object sans browsing context
Product: WebKit Reporter: Anne van Kesteren <annevk>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, commit-queue, ews-watchlist, ggaren, rniwa, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 191139    
Bug Blocks:    
Attachments:
Description Flags
WIP Patch
none
WIP Patch
none
WIP Patch
none
WIP Patch
none
Patch
none
Archive of layout-test-results from ews113 for mac-sierra
none
Patch none

Anne van Kesteren
Reported 2018-10-30 03:41:57 PDT
https://github.com/whatwg/html/issues/3959 describes how Location objects are not interoperable across browsers as well as some research as what browsers could align on here that would most likely be web-compatible and somewhat reasonable. https://github.com/whatwg/html/pull/4076 describes the change to the HTML Standard needed for this and https://github.com/web-platform-tests/wpt/pull/13435 has tests.
Attachments
WIP Patch (10.92 KB, patch)
2018-10-31 16:55 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
WIP Patch (11.12 KB, patch)
2018-10-31 16:57 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
WIP Patch (11.73 KB, patch)
2018-11-01 10:30 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
WIP Patch (18.92 KB, patch)
2018-11-01 11:07 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (22.87 KB, patch)
2018-11-01 12:03 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews113 for mac-sierra (3.49 MB, application/zip)
2018-11-01 13:53 PDT, EWS Watchlist 		no flags
Details
Patch (22.94 KB, patch)
2018-11-01 13:55 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2018-10-30 11:39:16 PDT
Sure, will do the necessary updates once the tests have landed.
Chris Dumez
Comment 2 2018-10-31 16:55:55 PDT
Created attachment 353558 [details] WIP Patch
Chris Dumez
Comment 3 2018-10-31 16:57:49 PDT
Created attachment 353559 [details] WIP Patch
Chris Dumez
Comment 4 2018-11-01 10:30:43 PDT
Created attachment 353614 [details] WIP Patch
Chris Dumez
Comment 5 2018-11-01 11:07:32 PDT
Created attachment 353621 [details] WIP Patch
Chris Dumez
Comment 6 2018-11-01 12:03:48 PDT
Created attachment 353627 [details] Patch
Geoffrey Garen
Comment 7 2018-11-01 13:39:50 PDT
Comment on attachment 353627 [details] Patch Seems like these might be real? imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/assign_after_load.html [ Failure ] imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/assign_before_load.html [ Failure ]
Chris Dumez
Comment 8 2018-11-01 13:40:19 PDT
(In reply to Geoffrey Garen from comment #7) > Comment on attachment 353627 [details] > Patch > > Seems like these might be real? > > > imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/ > assign_after_load.html [ Failure ] > > imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/ > assign_before_load.html [ Failure ] No.
Chris Dumez
Comment 9 2018-11-01 13:48:12 PDT
(In reply to Chris Dumez from comment #8) > (In reply to Geoffrey Garen from comment #7) > > Comment on attachment 353627 [details] > > Patch > > > > Seems like these might be real? > > > > > > imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/ > > assign_after_load.html [ Failure ] > > > > imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/ > > assign_before_load.html [ Failure ] > > No. Just tests that I imported earlier today from WPT and are flaky on WK1 bots: https://trac.webkit.org/r237698
EWS Watchlist
Comment 10 2018-11-01 13:53:44 PDT
Comment on attachment 353627 [details] Patch Attachment 353627 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9818066 New failing tests: imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/assign_after_load.html imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/assign_before_load.html
EWS Watchlist
Comment 11 2018-11-01 13:53:46 PDT
Created attachment 353640 [details] Archive of layout-test-results from ews113 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-sierra Platform: Mac OS X 10.12.6
Chris Dumez
Comment 12 2018-11-01 13:55:00 PDT
Created attachment 353641 [details] Patch
Geoffrey Garen
Comment 13 2018-11-01 14:14:56 PDT
Comment on attachment 353641 [details] Patch r=me
WebKit Commit Bot
Comment 14 2018-11-01 14:40:24 PDT
Comment on attachment 353641 [details] Patch Clearing flags on attachment: 353641 Committed r237702: <https://trac.webkit.org/changeset/237702>
WebKit Commit Bot
Comment 15 2018-11-01 14:40:26 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 16 2018-11-01 14:41:24 PDT
<rdar://problem/45742743>
Note You need to log in before you can comment on or make changes to this bug.