Bug 191046

Summary: [PSON] When process-swapping for a POST request the HTTP body gets dropped
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, ggaren, koivisto, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=201950
Bug Depends on:    
Bug Blocks: 191138    
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2018-10-29 15:55:11 PDT
When process-swapping for a POST request the HTTP body gets dropped, only various sites to fail when PSON is enabled.
Attachments
Patch (18.60 KB, patch)
2018-10-29 16:01 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (22.45 KB, patch)
2018-10-31 08:44 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2018-10-29 15:55:28 PDT
<rdar://problem/45229732>
Chris Dumez
Comment 2 2018-10-29 16:01:01 PDT
Created attachment 353329 [details] Patch
Alex Christensen
Comment 3 2018-10-30 18:47:27 PDT
Comment on attachment 353329 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353329&action=review > Source/WebKit/UIProcess/WebPageProxy.cpp:4189 > + // Make the request whole again before passing it to decidePolicyForNavigationAction(). > + request.setHTTPBody(requestBody.takeData()); Would it not be better to move this logic to decidePolicyForNavigationAction so we don't have duplicate code? There could be one comment there explaining why. > LayoutTests/http/tests/misc/form-post-textplain-cross-site.html:3 > +<title>Regression test for bug 20795 and 100445</title> And 191046?
Chris Dumez
Comment 4 2018-10-31 08:44:00 PDT
Created attachment 353497 [details] Patch
WebKit Commit Bot
Comment 5 2018-10-31 09:23:36 PDT
Comment on attachment 353497 [details] Patch Clearing flags on attachment: 353497 Committed r237639: <https://trac.webkit.org/changeset/237639>
WebKit Commit Bot
Comment 6 2018-10-31 09:23:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.