Bug 191000
| Summary: | REGRESSION(r237245): Regressed several input element tests | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> |
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | ap, bugs-noreply, magomez, mcatanzaro, webkit-bug-importer, wenson_hsieh |
| Priority: | P2 | ||
| Version: | Other | ||
| Hardware: | PC | ||
| OS: | Linux | ||
Michael Catanzaro
r237245 introduced three unexpected layout test progressions:
imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-badInput.html
imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-willValidate.html
imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/selection.html
which is great; I'll update those expectations now. But it also introduced two regressions:
imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/hidden.html
imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/text.html
There are text diffs:
--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/hidden-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/hidden-actual.txt
@@ -6,7 +6,7 @@
PASS files attribute must return null for hidden
PASS valueAsDate attribute must return null for hidden
PASS valueAsNumber attribute must return NaN for hidden
-PASS list attribute must return null for hidden
+FAIL list attribute must return null for hidden assert_equals: expected (object) null but got (undefined) undefined
PASS stepDown does not apply for hidden
PASS stepUp does not apply for hidden
PASS input type=hidden is barred from constraint validation
--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/text-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/text-actual.txt
@@ -7,7 +7,7 @@
PASS files attribute must return null for text
PASS valueAsDate attribute must return null for text
PASS valueAsNumber attribute must return NaN for text
-PASS list attribute must return null for text
+FAIL list attribute must return null for text assert_equals: expected (object) null but got (undefined) undefined
PASS stepDown does not apply for text
PASS stepUp does not apply for text
PASS Value returns the current value for search
@@ -16,7 +16,7 @@
PASS files attribute must return null for search
PASS valueAsDate attribute must return null for search
PASS valueAsNumber attribute must return NaN for search
-PASS list attribute must return null for search
+FAIL list attribute must return null for search assert_equals: expected (object) null but got (undefined) undefined
PASS stepDown does not apply for search
PASS stepUp does not apply for search
(I wonder how much work it would be to get these new input elements hooked up for WPE/GTK.)
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Michael Catanzaro
(In reply to Michael Catanzaro from comment #0)
> r237245 introduced three unexpected layout test progressions
This was "Enable the datalist element by default on iOS and macOS"
Michael Catanzaro
Also imported/w3c/web-platform-tests/shadow-dom/input-element-list.html:
--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/shadow-dom/input-element-list-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/shadow-dom/input-element-list-actual.txt
@@ -1,5 +1,5 @@
-FAIL Input element's list attribute should point to the datalist element. assert_equals: expected Element node <datalist id="datalist"></datalist> but got null
-FAIL Input element's list attribute should point to the datalist element in Shadow DOM. assert_equals: expected Element node <datalist id="datalist"></datalist> but got null
+FAIL Input element's list attribute should point to the datalist element. assert_equals: expected (object) null but got (undefined) undefined
+FAIL Input element's list attribute should point to the datalist element in Shadow DOM. assert_equals: expected (object) null but got (undefined) undefined
Wenson Hsieh
Thanks for the heads up, Michael! I'll take a look shortly...
Miguel Gomez
These are now passing
imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/hidden.html
imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/text.html