Bug 190988

Summary:

Web Inspector: prevent Canvas tab from listening for "space" when not visibile

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

190754

Attachments:

Description	Flags
Patch	none
Patch	none

Devin Rousso

Reported 2018-10-27 11:00:10 PDT

Attachments
Patch (2.39 KB, patch) 2018-10-27 11:02 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (2.41 KB, patch) 2018-10-27 11:09 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Devin Rousso

Comment 1 2018-10-27 11:02:36 PDT

Created attachment 353236 [details] Patch

EWS Watchlist

Comment 2 2018-10-27 11:04:45 PDT Comment hidden (obsolete)

Attachment 353236 [details] did not pass style-queue: ERROR: Source/WebInspectorUI/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Devin Rousso

Comment 3 2018-10-27 11:09:55 PDT

Created attachment 353240 [details] Patch Whoops. Forgot bug number.

WebKit Commit Bot

Comment 4 2018-10-29 12:13:08 PDT

Comment on attachment 353240 [details] Patch Clearing flags on attachment: 353240 Committed r237560: <https://trac.webkit.org/changeset/237560>

WebKit Commit Bot

Comment 5 2018-10-29 12:13:09 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 6 2018-10-29 13:31:40 PDT

<rdar://problem/45647159>

Radar WebKit Bug Importer

Comment 7 2018-10-29 13:31:45 PDT

<rdar://problem/45647158>

Note You need to log in before you can comment on or make changes to this bug.