Bug 190965
| Summary: | [macOS WK2 Release] storage/indexeddb/modern/opendatabase-after-storage-crash.html is a flaky timeout | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Matt Lewis <jlewis3> |
| Component: | Service Workers | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | beidson, cdumez, ryanhaddad, sihui_liu, tsavell, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Matt Lewis
storage/indexeddb/modern/opendatabase-after-storage-crash.html is a flaky timeout on macOS WK2 Release testers.
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=storage%2Findexeddb%2Fmodern%2Fopendatabase-after-storage-crash.html
https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r237460%20(7444)/results.html
the test usually times out with a time around 100-150s
diff:
--- /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/storage/indexeddb/modern/opendatabase-after-storage-crash-expected.txt
+++ /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/storage/indexeddb/modern/opendatabase-after-storage-crash-actual.txt
@@ -1,2 +1,5 @@
-PASS sessionStorage[storageKey] is "Made it"
-Successfully opened database with version 3.
+#PID UNRESPONSIVE - com.apple.WebKit.WebContent.Development (pid 5396)
+FAIL: Timed out waiting for notifyDone to be called
+
+#EOF
+#EOF
Based on the test history, this was previously flaky and fixed in https://trac.webkit.org/changeset/235415/webkit however it was one of the test that were touched in https://trac.webkit.org/changeset/236035/webkit when the Move of IndexedDB to Network Process happened. The dashboard shows it having started happening as far back as 10/2/2018, but it looks like it was happening before this. I have a feeling the change over may havebBrought some of the flakiness back.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Sihui Liu
This test should be not flaky after https://bugs.webkit.org/show_bug.cgi?id=198090.
Radar WebKit Bug Importer
<rdar://problem/51195220>