JSContext Inspector: Broken frontend, DOMAgent is used but does not exist

• Component: Web Inspector
• Status: RESOLVED FIXED

[Joseph Pecoraro]

JSContext Inspector: Broken frontend, DOMAgent is used but does not exist

Steps to Reproduce:
1. Attempt to inspect a JSContext (jsc --remote-debug)
  => Inspector does not show, early error

[Error] ReferenceError: Can't find variable: DOMAgent
	requestDocument (Main.js:23726)
	ensureDocument (Main.js:23728)
	DOMManager (Main.js:23716:340)
	loaded (Main.js:25221:295)
	initialize (Main.js:25693:92)
	Global Code (Main.html:43)

[Radar WebKit Bug Importer]

<rdar://problem/45569827>

[Joseph Pecoraro]

Created attachment 353120 [details]
[PATCH] Proposed Fix

[Devin Rousso]

Comment on attachment 353120 [details]
[PATCH] Proposed Fix

r=me

While I do think this is a valid solution, I think it would better to wrap the `ensureDocument` call in a similar if (or even introduce a `WI.DOMManager.supported()` like some other managers).  I'd prefer to check for support at the construction point rather than right before the call.

[Joseph Pecoraro]

(In reply to Devin Rousso from comment #3)
> Comment on attachment 353120 [details]
> [PATCH] Proposed Fix
> 
> r=me
> 
> While I do think this is a valid solution, I think it would better to wrap
> the `ensureDocument` call in a similar if (or even introduce a
> `WI.DOMManager.supported()` like some other managers).  I'd prefer to check
> for support at the construction point rather than right before the call.

Yes. In the near future, agent's won't be available in Manager construction and things like this will only happen when targets are supported. So this is a simple solution for now.

[WebKit Commit Bot]

Comment on attachment 353120 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 353120

Committed r237435: <https://trac.webkit.org/changeset/237435>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.