Bug 190916

Summary: Clean up some obsolete MAX_ALLOWED macros
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebKit Misc.Assignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, mitz, ryanhaddad, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch
none
proposed patch
none
proposed patch none

Alexey Proskuryakov
Reported 2018-10-25 13:32:33 PDT
Clean up some obsolete MAX_ALLOWED macros
Attachments
proposed patch (33.26 KB, patch)
2018-10-25 13:38 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
proposed patch (36.60 KB, patch)
2018-10-25 14:00 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
proposed patch (35.58 KB, patch)
2018-10-29 10:00 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2018-10-25 13:38:24 PDT
Created attachment 353104 [details] proposed patch
Alexey Proskuryakov
Comment 2 2018-10-25 14:00:02 PDT
Created attachment 353107 [details] proposed patch
Alexey Proskuryakov
Comment 3 2018-10-29 10:00:03 PDT
Created attachment 353293 [details] proposed patch
Tim Horton
Comment 4 2018-10-30 15:09:36 PDT
Comment on attachment 353293 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=353293&action=review > Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:86 > -#elif __MAC_OS_X_VERSION_MIN_REQUIRED < 101302 > +#elif __MAC_OS_X_VERSION_MIN_REQUIRED < 101400 No justification?
Alexey Proskuryakov
Comment 5 2018-10-30 15:16:48 PDT
There is no change here - __MAC_OS_X_VERSION_MIN_REQUIRED can be 101300 or 101400, not not anything in between.
WebKit Commit Bot
Comment 6 2018-10-30 15:45:37 PDT
Comment on attachment 353293 [details] proposed patch Clearing flags on attachment: 353293 Committed r237607: <https://trac.webkit.org/changeset/237607>
WebKit Commit Bot
Comment 7 2018-10-30 15:45:38 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2018-10-30 15:46:27 PDT
<rdar://problem/45683831>
Alex Christensen
Comment 9 2018-11-02 14:35:39 PDT
This seems to have broken some iOS builds: https://webkit-queues.webkit.org/results/9836096
Alexey Proskuryakov
Comment 10 2018-11-02 15:47:59 PDT
Oh wow, that's still on iPhoneOS11.3.sdk! Will get it upgraded ASAP. Thank you for pointing it out!
Note You need to log in before you can comment on or make changes to this bug.