Bug 190916

Summary: Clean up some obsolete MAX_ALLOWED macros
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebKit Misc.Assignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, mitz, ryanhaddad, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch
none
proposed patch
none
proposed patch none

Description Alexey Proskuryakov 2018-10-25 13:32:33 PDT 
Clean up some obsolete MAX_ALLOWED macros
Comment 1 Alexey Proskuryakov 2018-10-25 13:38:24 PDT 
Created attachment 353104 [details]
proposed patch
Comment 2 Alexey Proskuryakov 2018-10-25 14:00:02 PDT 
Created attachment 353107 [details]
proposed patch
Comment 3 Alexey Proskuryakov 2018-10-29 10:00:03 PDT 
Created attachment 353293 [details]
proposed patch
Comment 4 Tim Horton 2018-10-30 15:09:36 PDT 
Comment on attachment 353293 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353293&action=review

> Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:86
> -#elif __MAC_OS_X_VERSION_MIN_REQUIRED < 101302
> +#elif __MAC_OS_X_VERSION_MIN_REQUIRED < 101400

No justification?
Comment 5 Alexey Proskuryakov 2018-10-30 15:16:48 PDT 
There is no change here - __MAC_OS_X_VERSION_MIN_REQUIRED can be 101300 or 101400, not not anything in between.
Comment 6 WebKit Commit Bot 2018-10-30 15:45:37 PDT 
Comment on attachment 353293 [details]
proposed patch

Clearing flags on attachment: 353293

Committed r237607: <https://trac.webkit.org/changeset/237607>
Comment 7 WebKit Commit Bot 2018-10-30 15:45:38 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-10-30 15:46:27 PDT 
<rdar://problem/45683831>
Comment 9 Alex Christensen 2018-11-02 14:35:39 PDT 
This seems to have broken some iOS builds: https://webkit-queues.webkit.org/results/9836096
Comment 10 Alexey Proskuryakov 2018-11-02 15:47:59 PDT 
Oh wow, that's still on iPhoneOS11.3.sdk! Will get it upgraded ASAP. Thank you for pointing it out!