Bug 190915

Summary:

[PSON] Navigating cross-site with locked history but unlocked back/forward list fails to create a new BackForwardListItem

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

WebKit2

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, commit-queue, dbates, ews-watchlist, ggaren, japhet, koivisto, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Chris Dumez 2018-10-25 13:19:19 PDT

Navigating cross-site with locked history but unlocked back/forward list fails to create a new BackForwardListItem and updates the current one instead.

Comment 1 Chris Dumez 2018-10-25 13:19:36 PDT

<rdar://problem/45059069>

Comment 2 Chris Dumez 2018-10-25 13:35:12 PDT

Created attachment 353103 [details]
Patch

Comment 3 EWS Watchlist 2018-10-25 13:37:55 PDT

Attachment 353103 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:283:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:304:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:306:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:313:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
Total errors found: 4 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 4 Geoffrey Garen 2018-10-25 21:41:21 PDT

Comment on attachment 353103 [details]
Patch

r=me

Comment 5 WebKit Commit Bot 2018-10-25 22:06:34 PDT

Comment on attachment 353103 [details]
Patch

Clearing flags on attachment: 353103

Committed r237446: <https://trac.webkit.org/changeset/237446>

Comment 6 WebKit Commit Bot 2018-10-25 22:06:35 PDT

All reviewed patches have been landed.  Closing bug.