Bug 190907 – Fix clang static analyzer warning in StyleBuilderConverter.h

• Component: CSS
• Status: RESOLVED FIXED

[David Kilzer (:ddkilzer)]

Fix the following clang static warning in StyleBuilderConverter.h:
    Value stored to 'autoFlow' during its initialization is never read

[David Kilzer (:ddkilzer)]

Created attachment 353094 [details]
Patch v1

[David Kilzer (:ddkilzer)]

This fixes 7 clang static analyzer warnings in WebCore where this code is inlined.

[David Kilzer (:ddkilzer)]

Comment on attachment 353094 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=353094&action=review

> Source/WebCore/css/StyleBuilderConverter.h:1069
>      case CSSValueDense:
>          if (second && second->valueID() == CSSValueColumn)
> -            return AutoFlowColumnDense;
> -        return AutoFlowRowDense;
> +            autoFlow = AutoFlowColumnDense;
> +        else
> +            autoFlow = AutoFlowRowDense;
> +        break;

BTW, if the preference is to change this `switch` statement to use early returns everywhere, I'm happy to do that instead.

[Don Olmstead]

(In reply to David Kilzer (:ddkilzer) from comment #3)
> Comment on attachment 353094 [details]
> Patch v1
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=353094&action=review
> 
> > Source/WebCore/css/StyleBuilderConverter.h:1069
> >      case CSSValueDense:
> >          if (second && second->valueID() == CSSValueColumn)
> > -            return AutoFlowColumnDense;
> > -        return AutoFlowRowDense;
> > +            autoFlow = AutoFlowColumnDense;
> > +        else
> > +            autoFlow = AutoFlowRowDense;
> > +        break;
> 
> BTW, if the preference is to change this `switch` statement to use early
> returns everywhere, I'm happy to do that instead.

Patch looks good to me since its keeping with the style in the rest of the method.

If you're going to do the early return maybe change them to use a ternary?

[Antti Koivisto]

Looks fine, stylistic improvements can be done separately.

[WebKit Commit Bot]

Comment on attachment 353094 [details]
Patch v1

Clearing flags on attachment: 353094

Committed r237557: <https://trac.webkit.org/changeset/237557>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/45647183>