Bug 190888

Summary: [ iOS Simulator Release ] Layout Test fast/animation/request-animation-frame.html is a flaky failure.
Product: WebKit Reporter: Matt Lewis <jlewis3>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED CONFIGURATION CHANGED    
Severity: Normal CC: commit-queue, graouts, koivisto, ryanhaddad, simon.fraser, sroberts, tsavell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Matt Lewis 2018-10-24 14:27:41 PDT
The following layout test is flaky on iOS 12 Release Simulator

fast/animation/request-animation-frame.html

Probable cause:

based on the dashboard, this has been failing for quite some time.

Flakiness Dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fanimation%2Frequest-animation-frame.html

https://build.webkit.org/results/Apple%20iOS%2012%20Simulator%20Release%20WK2%20(Tests)/r237393%20(517)/results.html
https://build.webkit.org/builders/Apple%20iOS%2012%20Simulator%20Release%20WK2%20%28Tests%29/builds/517


Diff:

--- /Volumes/Data/slave/ios-simulator-12-release-tests-wk2/build/layout-test-results/fast/animation/request-animation-frame-expected.txt
+++ /Volumes/Data/slave/ios-simulator-12-release-tests-wk2/build/layout-test-results/fast/animation/request-animation-frame-actual.txt
@@ -3,7 +3,7 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-PASS callbackInvoked is true
+FAIL callbackInvoked should be true. Was false.
 PASS successfullyParsed is true
 
 TEST COMPLETE
Comment 1 Radar WebKit Bug Importer 2018-10-24 14:28:07 PDT
<rdar://problem/45533441>
Comment 2 Shawn Roberts 2019-01-25 14:37:53 PST
Created attachment 360166 [details]
Patch
Comment 3 WebKit Commit Bot 2019-01-25 15:16:33 PST
Comment on attachment 360166 [details]
Patch

Clearing flags on attachment: 360166

Committed r240515: <https://trac.webkit.org/changeset/240515>
Comment 4 WebKit Commit Bot 2019-01-25 15:16:34 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Alexey Proskuryakov 2019-05-11 15:29:55 PDT
This patch only marked the test as flaky, the issue was not fixed.

However, I don't see any failures on this bot on the flakiness dashboard.  Removed the expectation in http://trac.webkit.org/r245209