Summary: | Web Inspector: Canvas: capture changes to <canvas> that would affect the recorded context | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||||||
Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | cdumez, commit-queue, esprehn+autocc, ews-watchlist, gyuyoung.kim, hi, inspector-bugzilla-changes, kondapallykalyan, mattbaker, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | All | ||||||||||||
OS: | All | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 173807 | ||||||||||||
Attachments: |
|
Description
Devin Rousso
2018-10-23 18:39:03 PDT
Created attachment 353264 [details]
Patch
Created attachment 353265 [details]
[Image] After Patch is applied
Created attachment 353266 [details]
Patch
Whoops. Forgot to stage a few things before uploading.
Comment on attachment 353266 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353266&action=review > Source/WebInspectorUI/ChangeLog:17 > + `context`'s `canvas` instead of directly to the `context`). The context replacers for all three context types are the same, but are ordered differently. Why is this? Why have these values at all if they are always "canvas"? > Source/WebCore/bindings/js/CallTracer.cpp:35 > +void CallTracer::recordCanvasAction(HTMLCanvasElement& canvasElement, const String& name, Vector<RecordCanvasActionVariant>&& parameters) Can we pass HTMLCanvasElement as a const reference? CanvasBase::renderingContent() is a const member function that returns a non-const pointer, so you shouldn't need to make a bunch of other stuff const to plumb the value through to InspectorInstrumentation. Created attachment 353781 [details]
Patch
Comment on attachment 353781 [details]
Patch
r=me
Comment on attachment 353781 [details] Patch Clearing flags on attachment: 353781 Committed r237777: <https://trac.webkit.org/changeset/237777> All reviewed patches have been landed. Closing bug. |