Summary: | Really prevent PLATFORM(IOS) from being used | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||||||
Component: | Web Template Framework | Assignee: | Alexey Proskuryakov <ap> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, dbates, ews-watchlist, mitz, ryanhaddad, simon.fraser, thorton, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | Other | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Alexey Proskuryakov
2018-10-22 16:33:35 PDT
Created attachment 352922 [details]
proposed patch
Created attachment 352951 [details]
proposed patch
Better to include all changes.
Comment on attachment 352951 [details] proposed patch Attachment 352951 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9702564 New failing tests: fast/box-shadow/box-shadow-with-zero-radius.html Created attachment 352959 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
The EWS failure is real. This patch fixes preprocessor guards added in bug 190155, and that used to cause the same failure in earlier iterations. Anyway, this patch is ready for review. I'll talk to Said about what's right to do here, but any changes will be of build fix/rollback kind, not related to the substance of this change. (In reply to Alexey Proskuryakov from comment #5) > The EWS failure is real. This patch fixes preprocessor guards added in bug > 190155, and that used to cause the same failure in earlier iterations. I rolled out the change for 190155 in https://trac.webkit.org/changeset/237359 Committed http://trac.webkit.org/r237361 |