Bug 190753
| Summary: | 'all' shorthand not serialized in cssText | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Oriol Brufau <obrufau> |
| Component: | CSS | Assignee: | Oriol Brufau <obrufau> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ahmad.saleem792, ap, bfulgham, rniwa, simon.fraser, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=190496 https://github.com/web-platform-tests/wpt/pull/36290 |
||
| Bug Depends on: | |||
| Bug Blocks: | 216170 | ||
Oriol Brufau
Run this code:
document.body.style.cssText = "all: inherit";
document.body.style.cssText;
Expected result:
"all: inherit;"
Actual result:
"color: inherit; display: inherit; font-family: inherit; font-feature-settings: inherit; .....
Specifications:
https://drafts.csswg.org/cssom/#serialize-a-css-declaration-block
https://drafts.csswg.org/css-cascade/#all-shorthand
Works in Firefox and Chromium.
This would be fixed by bug 190496.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
I am able to reproduce this bug in Safari 15.6 on macOS 12.5 and all other browsers (Chrome Canary 106 and Firefox Nightly 105) show expected output from Comment 0. While Safari show "Actual Result" from Comment 0. Just wanted to update latest results. Thanks!
Radar WebKit Bug Importer
<rdar://problem/97694235>
Oriol Brufau
I no longer think this needs bug 190496. Probably it's just a matter of adding CSSPropertyAll into the 'shorthands' vector in StyleProperties::asTextInternal.
https://searchfox.org/wubkat/rev/e8e9be7353991aee7df45aa62f0e0148f16e6f9f/Source/WebCore/css/StyleProperties.cpp#1616
Oriol Brufau
Pull request: https://github.com/WebKit/WebKit/pull/5029
EWS
Committed 255329@main (4481e38af645): <https://commits.webkit.org/255329@main>
Reviewed commits have been landed. Closing PR #5029 and removing active labels.