Bug 190752

Summary: Use WTF::Function instead of std::function as much as possible
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: NEW    
Severity: Normal CC: achristensen, cdumez, darin, ggaren, mark.lam, saam, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch saam: review-

Yusuke Suzuki
Reported 2018-10-19 08:56:49 PDT
Use WTF::Function instead of std::function as much as possible
Attachments
Patch (31.97 KB, patch)
2018-10-19 08:58 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (30.87 KB, patch)
2018-10-19 10:53 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (27.63 KB, patch)
2018-10-19 10:58 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (23.49 KB, patch)
2018-10-19 12:07 PDT, Yusuke Suzuki 		saam: review-
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2018-10-19 08:58:10 PDT
Created attachment 352786 [details] Patch
Alex Christensen
Comment 2 2018-10-19 10:14:47 PDT
Comment on attachment 352786 [details] Patch We shouldn't need WTF:: anywhere in this patch.
Yusuke Suzuki
Comment 3 2018-10-19 10:53:33 PDT
Created attachment 352801 [details] Patch
Yusuke Suzuki
Comment 4 2018-10-19 10:54:36 PDT
(In reply to Alex Christensen from comment #2) > Comment on attachment 352786 [details] > Patch > > We shouldn't need WTF:: anywhere in this patch. Thanks, fixed.
Yusuke Suzuki
Comment 5 2018-10-19 10:58:41 PDT
Created attachment 352803 [details] Patch
Yusuke Suzuki
Comment 6 2018-10-19 12:07:26 PDT
Created attachment 352812 [details] Patch
Chris Dumez
Comment 7 2018-10-22 08:58:48 PDT
Bubbles are red.
Saam Barati
Comment 8 2019-01-20 13:38:21 PST
Comment on attachment 352812 [details] Patch r- because this is old and EWS was unhappy.
Note You need to log in before you can comment on or make changes to this bug.