Bug 190729

Summary:

Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

WebKit Misc.

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch	none
proposed patch	none

Alexey Proskuryakov

Reported 2018-10-18 11:53:02 PDT

Just a mass find and replace. PLATFORM(IOS) -> PLATFORM(IOS_FAMILY) PLATFORM(IOS_SIMULATOR) -> PLATFORM(IOS_FAMILY_SIMULATOR) OS(IOS) -> OS(IOS_FAMILY) OS(IOS_SIMULATOR) -> OS(IOS_FAMILY_SIMULATOR) # none found WTF_PLATFORM_IOS -> WTF_PLATFORM_IOS_FAMILY # excluding definition WTF_OS_IOS -> WTF_OS_IOS_FAMILY # none found, except for the definition Excluding ChangeLogs of course.

Attachments
proposed patch (1.53 MB, patch) 2018-10-18 12:07 PDT, Alexey Proskuryakov	no flags	Details Formatted Diff Diff
proposed patch (1.53 MB, patch) 2018-10-18 13:03 PDT, Alexey Proskuryakov	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Alexey Proskuryakov

Comment 1 2018-10-18 12:07:32 PDT

Created attachment 352714 [details] proposed patch

EWS Watchlist

Comment 2 2018-10-18 12:13:30 PDT

Attachment 352714 [details] did not pass style-queue: ERROR: Source/WebKitLegacy/ios/WebCoreSupport/WebFrameIOS.mm:953: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebKit/Shared/WebEventConversion.cpp:371: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:2041: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/WebKitLegacy/ios/WebCoreSupport/WebSelectionRect.m:204: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebKit/UIProcess/ios/forms/WKFormSelectPopover.mm:466: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebKit/UIProcess/ios/forms/WKFormSelectControl.mm:124: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebKit/UIProcess/ios/forms/WKFormSelectPicker.mm:455: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebKitLegacy/ios/WebCoreSupport/WebMIMETypeRegistry.mm:58: One space before end of line comments [whitespace/comments] [5] Total errors found: 8 in 1224 files If any of these errors are false positives, please file a bug against check-webkit-style.

Alexey Proskuryakov

Comment 3 2018-10-18 13:03:25 PDT

Created attachment 352721 [details] proposed patch With fewer mistakes.

EWS Watchlist

Comment 4 2018-10-18 13:09:03 PDT

Attachment 352721 [details] did not pass style-queue: ERROR: Source/WebKitLegacy/ios/WebCoreSupport/WebFrameIOS.mm:953: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebKit/Shared/WebEventConversion.cpp:371: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:2041: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/WebKitLegacy/ios/WebCoreSupport/WebSelectionRect.m:204: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebKit/UIProcess/ios/forms/WKFormSelectPopover.mm:466: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebKit/UIProcess/ios/forms/WKFormSelectControl.mm:124: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebKit/UIProcess/ios/forms/WKFormSelectPicker.mm:455: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebKitLegacy/ios/WebCoreSupport/WebMIMETypeRegistry.mm:58: One space before end of line comments [whitespace/comments] [5] Total errors found: 8 in 1224 files If any of these errors are false positives, please file a bug against check-webkit-style.

Tim Horton

Comment 5 2018-10-18 13:47:15 PDT

Comment on attachment 352721 [details] proposed patch rs=me

WebKit Commit Bot

Comment 6 2018-10-18 14:39:22 PDT

Comment on attachment 352721 [details] proposed patch Clearing flags on attachment: 352721 Committed r237266: <https://trac.webkit.org/changeset/237266>

WebKit Commit Bot

Comment 7 2018-10-18 14:39:23 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 8 2018-10-18 14:40:32 PDT

<rdar://problem/45384902>

Note You need to log in before you can comment on or make changes to this bug.