Bug 190689
Summary: | JSHTMLCollection needs isReachableFromOpaqueRoots override to keep themselves alive | ||
---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
Component: | DOM | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED INVALID | ||
Severity: | Normal | CC: | cdumez, ggaren, keith_miller, mark.lam, webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified |
Ryosuke Niwa
It's incorrect to let HTML collections be GC'ed while its element is alive.
It also seems like both JSNodeList and JSHTMLCollection needs to have root(~) function point to the owner node's root.
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/45350273>
Ryosuke Niwa
Actually, JSHTMLCollection already implements isReachableFromOpaqueRoots, and makes it reachable from the element.