Bug 190675

Summary: BackForwardClient needs to be able to support UIProcess-only back/forward lists
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, cdumez, dbates, ews-watchlist, japhet, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch cdumez: review+

Alex Christensen
Reported 2018-10-17 12:03:17 PDT
BackForwardClient needs to be able to support UIProcess-only back/forward lists
Attachments
Patch (27.90 KB, patch)
2018-10-17 12:11 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (27.88 KB, patch)
2018-10-17 12:13 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (27.87 KB, patch)
2018-10-17 12:47 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (29.83 KB, patch)
2018-10-17 12:59 PDT, Alex Christensen 		cdumez: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2018-10-17 12:11:11 PDT
Created attachment 352606 [details] Patch
Alex Christensen
Comment 2 2018-10-17 12:13:20 PDT
Created attachment 352607 [details] Patch
Alex Christensen
Comment 3 2018-10-17 12:47:34 PDT
Created attachment 352616 [details] Patch
Alex Christensen
Comment 4 2018-10-17 12:59:14 PDT
Created attachment 352621 [details] Patch
Alex Christensen
Comment 5 2018-10-17 13:37:50 PDT
http://trac.webkit.org/r237233
Radar WebKit Bug Importer
Comment 6 2018-10-17 13:38:22 PDT
<rdar://problem/45349080>
Daniel Bates
Comment 7 2018-10-17 13:53:56 PDT
Comment on attachment 352621 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352621&action=review > Source/WebCore/ChangeLog:10 > + Also use unsigned for the back and forward list counts because they can never be negative. This may be true. I do not think this fact is best conveyed using unsigned. Data types should be chosen based on the range of representable values needed for the problem being solved. It seems a key design decision for this class was to expose a getter than takes a delta and every other decision falls out from this. Maybe this isn’t the right design, but it seems intuitive and it comes with a nice property as shown in the implementation of count(): “back count” + 1 “forward count” represents the entire range of an int. And this has another nice property that iterating over all items is a for-loop from -“back count” to “forward count” (seen in the webPage.cpp code). I find it hard to imagine a client would have anything close to 2^31 - 1 history items backwards and/or forwards, but I find it inconceivable that a client would have 2^32 - 1 items backwards and/or forwards.
Alex Christensen
Comment 8 2018-10-17 14:06:21 PDT
Well counts that are never less than zero certainly don't need to be signed.
Note You need to log in before you can comment on or make changes to this bug.