Bug 190645

Summary: Web Inspector: ⌃G to jump to line in CSS file wipes the line
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, joepeck, mattbaker, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix
none
[PATCH] Proposed Fix
mattbaker: review+
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2018-10-16 15:20:10 PDT
⌃G to jump to line in CSS file wipes the line Steps to Reproduce: 1. Inspect <http://bogojoker.com/shell/> 2. Show "print.css" in the Resources tab 3. ⌃G to show the go to line dialog 4. Type "20" and press return => Line 20 is suddenly empty and cursor is on line 21
Attachments
[PATCH] Proposed Fix (5.68 KB, patch)
2018-10-16 16:44 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
[PATCH] Proposed Fix (5.83 KB, patch)
2018-10-16 16:54 PDT, Joseph Pecoraro 		mattbaker: review+
DetailsFormatted DiffDiff
[PATCH] Proposed Fix (5.83 KB, patch)
2018-10-16 18:17 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2018-10-16 16:44:40 PDT
Created attachment 352516 [details] [PATCH] Proposed Fix
Joseph Pecoraro
Comment 2 2018-10-16 16:54:39 PDT
Created attachment 352520 [details] [PATCH] Proposed Fix
Matt Baker
Comment 3 2018-10-16 17:08:23 PDT
Comment on attachment 352520 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=352520&action=review r=me > Source/WebInspectorUI/ChangeLog:14 > + it is clear this is only on a successful value and not an invalid valid. Wording: "an invalid valid" > Source/WebInspectorUI/ChangeLog:23 > + Prevent defaut on the event whenever we dismiss the dialog. defaut -> default
Joseph Pecoraro
Comment 4 2018-10-16 18:17:25 PDT
Created attachment 352532 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 5 2018-10-16 18:53:36 PDT
Comment on attachment 352532 [details] [PATCH] Proposed Fix Clearing flags on attachment: 352532 Committed r237212: <https://trac.webkit.org/changeset/237212>
Radar WebKit Bug Importer
Comment 6 2018-10-16 23:27:28 PDT
<rdar://problem/45330064>
Note You need to log in before you can comment on or make changes to this bug.