Bug 190634

Summary: isASTErroneous in offlineasm should de-macroify before looking for Errors
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, fujii.hironori, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mark.lam: review+

Keith Miller
Reported 2018-10-16 12:08:37 PDT
isASTErroneous in offlineasm should de-macroify before looking for Errors
Attachments
Patch (2.20 KB, patch)
2018-10-16 12:10 PDT, Keith Miller 		mark.lam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2018-10-16 12:10:13 PDT
Created attachment 352486 [details] Patch
Mark Lam
Comment 2 2018-10-16 12:13:13 PDT
Comment on attachment 352486 [details] Patch LGTM
Keith Miller
Comment 3 2018-10-16 12:16:31 PDT
Committed r237197: <https://trac.webkit.org/changeset/237197>
Radar WebKit Bug Importer
Comment 4 2018-10-16 12:17:29 PDT
<rdar://problem/45314169>
Fujii Hironori
Comment 5 2018-10-16 20:02:16 PDT
Reverted r237188, r237189, and r237197 for reason: It breaks WinCairo Debug builds and Release LayoutTests Committed r237214: <https://trac.webkit.org/changeset/237214>
Fujii Hironori
Comment 6 2018-10-17 21:09:17 PDT
Relanded https://trac.webkit.org/r237219
Note You need to log in before you can comment on or make changes to this bug.