Bug 190631

Summary: [Media] Use nanoseconds as MaximumTimeScale
Product: WebKit Reporter: Alicia Boya García <aboya>
Component: MediaAssignee: Alicia Boya García <aboya>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jer.noble, tsavell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 190691    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Alicia Boya García
Reported 2018-10-16 11:19:24 PDT
The current MediaTime::MaximumTimeScale is 0x7fffffff (2^31-1), which is quite undesirable: it's a prime number, so it does not accomodate *any* other timescale without rounding. I propose to use 1e9 (nanosecond timescale) as maximum timescale: it's very close to 2^31 (a bit under 2^30 actually) and it's already being used by both Matroska (WebM) and GStreamer.
Attachments
Patch (1.47 KB, patch)
2018-10-16 13:52 PDT, Alicia Boya García 		no flags
DetailsFormatted DiffDiff
Patch (4.99 KB, patch)
2018-10-17 21:26 PDT, Alicia Boya García 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2018-10-16 11:56:49 PDT
LGTM. The initial choice of maximum time scale was relatively arbitrary; it's less than 1/2 of the maximum possible value of a uint32_t.
Alicia Boya García
Comment 2 2018-10-16 13:52:10 PDT
Created attachment 352499 [details] Patch
WebKit Commit Bot
Comment 3 2018-10-16 16:18:16 PDT
Comment on attachment 352499 [details] Patch Clearing flags on attachment: 352499 Committed r237208: <https://trac.webkit.org/changeset/237208>
WebKit Commit Bot
Comment 4 2018-10-16 16:18:17 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2018-10-16 16:19:22 PDT
<rdar://problem/45322286>
Truitt Savell
Comment 7 2018-10-17 08:47:40 PDT
Linked wrong build. Correct build: https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK1%20%28Tests%29/builds/8636
Jer Noble
Comment 8 2018-10-17 09:22:42 PDT
Looks like these tests need rebaselining.
Truitt Savell
Comment 9 2018-10-17 13:53:45 PDT
Can this be fixed today?
WebKit Commit Bot
Comment 10 2018-10-17 15:51:19 PDT
Re-opened since this is blocked by bug 190691
Alicia Boya García
Comment 11 2018-10-17 17:18:47 PDT
Yes, the tests need a rebaseline indeed.
Alicia Boya García
Comment 12 2018-10-17 21:26:01 PDT
Created attachment 352683 [details] Patch
WebKit Commit Bot
Comment 13 2018-10-18 19:49:05 PDT
Comment on attachment 352683 [details] Patch Clearing flags on attachment: 352683 Committed r237278: <https://trac.webkit.org/changeset/237278>
WebKit Commit Bot
Comment 14 2018-10-18 19:49:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.