Bug 190617

Summary: Replace HistoryItem* with HistoryItem& where possible
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, dbates, ews-watchlist, japhet, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch cdumez: review+

Alex Christensen
Reported 2018-10-16 08:18:17 PDT
Replace HistoryItem* with HistoryItem& where possible
Attachments
Patch (23.71 KB, patch)
2018-10-16 08:22 PDT, Alex Christensen 		cdumez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2018-10-16 08:22:01 PDT
Created attachment 352452 [details] Patch
EWS Watchlist
Comment 2 2018-10-16 08:25:18 PDT
Attachment 352452 [details] did not pass style-queue: ERROR: Source/WebKitLegacy/win/BackForwardList.cpp:104: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 1 in 24 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alex Christensen
Comment 3 2018-10-16 08:58:26 PDT
http://trac.webkit.org/r237184
Radar WebKit Bug Importer
Comment 4 2018-10-16 08:59:23 PDT
<rdar://problem/45307489>
Note You need to log in before you can comment on or make changes to this bug.