Created attachment 352510[details]
Archive of layout-test-results from ews102 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 352512[details]
Archive of layout-test-results from ews104 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Created attachment 352513[details]
Archive of layout-test-results from ews204 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews204 Port: win-future Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit
Created attachment 352522[details]
Archive of layout-test-results from ews116 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 352533[details]
Archive of layout-test-results from ews102 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6
(In reply to Build Bot from comment #12)
> Comment on attachment 352523[details]
> Fix non-internal iOS build
>
> Attachment 352523[details] did not pass mac-ews (mac):
> Output: https://webkit-queues.webkit.org/results/9629442
>
> New failing tests:
> imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/
> selection-not-application.html
> fast/dom/Window/window-lookup-precedence.html
> imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/
> valueMode.html
> imported/w3c/web-platform-tests/dom/nodes/Node-cloneNode.html
> imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/
> readwrite-readonly.html
> imported/w3c/web-platform-tests/shadow-dom/input-element-list.html
> imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-
> validation-willValidate.html
> accessibility/roles-exposed.html
> imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/type-
> change-state.html
> fast/selectors/read-only-read-write-input-basics.html
> imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/
> selection.html
> imported/w3c/web-platform-tests/custom-elements/builtin-coverage.html
> imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-
> validation-validity-badInput.html
> imported/w3c/web-platform-tests/html/dom/reflection-forms.html
We're going to need to rebaseline tests for input type color as well, since input type color is currently enabled in WebKitLegacy (where it shouldn't be).
Created attachment 352535[details]
Archive of layout-test-results from ews112 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 352536[details]
Archive of layout-test-results from ews121 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Created attachment 352541[details]
Archive of layout-test-results from ews206 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Created attachment 352547[details]
Archive of layout-test-results from ews113 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 352548[details]
Archive of layout-test-results from ews205 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews205 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Created attachment 352549[details]
Archive of layout-test-results from ews124 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 352567[details]
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=352567&action=review> LayoutTests/fast/borders/empty-outline-border-assert-expected.txt:1
> +PASS if no ASSERT in debug.
This is actually a bad rebaseline! What's happening here is that since ENABLE(DATALIST_ELEMENT) is now on by default, the UA stylesheet now contains `datalist { display: none; }`. However, this rule doesn't respect the runtime-enabled feature flag, so everything under a datalist element is hidden, regardless of whether there is support for HTMLDataListElement.
This completely breaks fallback content inside datalists, in the case where the build flag is on but the runtime-enabled feature is off (i.e. legacy WebKit on macOS and iOS). The "aaaa…aaa" in this test should still be present in legacy WebKit.
> LayoutTests/imported/w3c/web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-newelements-expected.txt:30
> +
This is also an incorrect result in legacy WebKit, for the same reason (see empty-outline-border-assert-expected.txt).
> LayoutTests/imported/w3c/web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-newelements-xhtml-expected.txt:-4
> -
Ditto.
Created attachment 352638[details]
Archive of layout-test-results from ews102 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 352643[details]
Fix double ChangeLog
View in context: https://bugs.webkit.org/attachment.cgi?id=352643&action=review> Source/WebCore/rendering/RenderTheme.h:104
> +#if ENABLE(DATALIST_ELEMENT)
> + virtual String dataListStyleSheet() const { return { }; }
> +#endif
> +#if ENABLE(INPUT_TYPE_COLOR)
> + virtual String colorInputStyleSheet() const { return { }; }
> +#endif
This would break non-Apple ports. I don't think we should do that.
Either make Mac one the default style, or do a pre-processor in html.css which special-cases iOS code.
> Source/WebCore/rendering/RenderThemeIOS.mm:1356
> + ASSERT(RuntimeEnabledFeatures::sharedFeatures().inputTypeColorEnabled());
> + return "input[type=\"color\"] { width: 44px; height: 23px; outline: none; }"_s;
Do we really need to do this in .mm files?
Can't we just use the pre-processor in html.css?
(In reply to Ryosuke Niwa from comment #34)
> Comment on attachment 352643[details]
> Fix double ChangeLog
>
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=352643&action=review
>
> > Source/WebCore/rendering/RenderTheme.h:104
> > +#if ENABLE(DATALIST_ELEMENT)
> > + virtual String dataListStyleSheet() const { return { }; }
> > +#endif
> > +#if ENABLE(INPUT_TYPE_COLOR)
> > + virtual String colorInputStyleSheet() const { return { }; }
> > +#endif
>
> This would break non-Apple ports. I don't think we should do that.
> Either make Mac one the default style, or do a pre-processor in html.css
> which special-cases iOS code.
Sounds good — we can put this in a platform-agnostic file (RenderTheme.cpp). I'm not so sure we can put this in html.css with preprocessor checks though (refer to my other comment below).
>
> > Source/WebCore/rendering/RenderThemeIOS.mm:1356
> > + ASSERT(RuntimeEnabledFeatures::sharedFeatures().inputTypeColorEnabled());
> > + return "input[type=\"color\"] { width: 44px; height: 23px; outline: none; }"_s;
>
> Do we really need to do this in .mm files?
> Can't we just use the pre-processor in html.css?
I'm not sure how this would work, since whether we should include these UA styles depends on runtime-enabled features (rather than just a build-time flag).
2018-10-16 13:01 PDT, Wenson Hsieh
2018-10-16 14:10 PDT, Wenson Hsieh
2018-10-16 15:23 PDT, EWS Watchlist
2018-10-16 16:24 PDT, EWS Watchlist
2018-10-16 16:28 PDT, EWS Watchlist
2018-10-16 17:14 PDT, EWS Watchlist
2018-10-16 17:20 PDT, Wenson Hsieh
2018-10-16 18:35 PDT, EWS Watchlist
2018-10-16 19:27 PDT, EWS Watchlist
2018-10-16 19:29 PDT, EWS Watchlist
2018-10-16 19:37 PDT, EWS Watchlist
2018-10-16 21:27 PDT, EWS Watchlist
2018-10-16 21:38 PDT, EWS Watchlist
2018-10-16 21:39 PDT, EWS Watchlist
2018-10-17 08:24 PDT, Wenson Hsieh
2018-10-17 12:54 PDT, Wenson Hsieh
2018-10-17 14:14 PDT, EWS Watchlist
2018-10-17 14:28 PDT, Wenson Hsieh
2018-10-17 14:32 PDT, Wenson Hsieh
2018-10-17 19:14 PDT, Wenson Hsieh