Bug 190573

Summary: [GTK][WPE] Make libwebrtc compile using the system opus library
Product: WebKit Reporter: Alejandro G. Castro <alex>
Component: WebRTCAssignee: Alejandro G. Castro <alex>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, pnormand, tsaunier, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Alejandro G. Castro
Reported 2018-10-15 04:46:35 PDT
We found some issues when gstreamer tries to use opus because it finds opus libwebrtc symbols compiled inside WebKit. To avoid this problem we are going to use libopus from the system also for libwebrtc.
Attachments
Patch (11.80 KB, patch)
2018-10-15 04:51 PDT, Alejandro G. Castro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alejandro G. Castro
Comment 1 2018-10-15 04:51:52 PDT
Created attachment 352309 [details] Patch
Thibault Saunier
Comment 2 2018-10-15 04:57:52 PDT
Comment on attachment 352309 [details] Patch lgtm, informal r+
WebKit Commit Bot
Comment 3 2018-10-16 00:39:14 PDT
Comment on attachment 352309 [details] Patch Clearing flags on attachment: 352309 Committed r237174: <https://trac.webkit.org/changeset/237174>
WebKit Commit Bot
Comment 4 2018-10-16 00:39:16 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2018-10-16 00:40:43 PDT
<rdar://problem/45299053>
Note You need to log in before you can comment on or make changes to this bug.