Bug 190569

Summary: Web Inspector: Dark Mode: style editor warnings should not look like errors
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, mattbaker, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Image] Bug
none
Patch
none
[Image] With patch applied none

Nikita Vasilyev
Reported 2018-10-14 20:30:49 PDT
Created attachment 352293 [details] [Image] Bug Style editor warnings in the light mode have a light yellow background, like all warnings. In the dark mode, these warnings have a red background and look like errors.
Attachments
[Image] Bug (19.65 KB, image/png)
2018-10-14 20:30 PDT, Nikita Vasilyev 		no flags
Details
Patch (7.96 KB, patch)
2018-10-14 20:39 PDT, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
[Image] With patch applied (20.20 KB, image/png)
2018-10-14 20:40 PDT, Nikita Vasilyev 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-10-14 20:31:20 PDT
<rdar://problem/45261689>
Nikita Vasilyev
Comment 2 2018-10-14 20:39:28 PDT
Created attachment 352295 [details] Patch
Nikita Vasilyev
Comment 3 2018-10-14 20:40:00 PDT
Created attachment 352296 [details] [Image] With patch applied
Nikita Vasilyev
Comment 4 2018-10-14 20:55:23 PDT
To test manually: http://nv.github.io/webkit-inspector-bugs/190569_warning-styles/
Matt Baker
Comment 5 2018-10-15 10:04:30 PDT
Comment on attachment 352295 [details] Patch r=me
WebKit Commit Bot
Comment 6 2018-10-15 10:27:09 PDT
Comment on attachment 352295 [details] Patch Clearing flags on attachment: 352295 Committed r237125: <https://trac.webkit.org/changeset/237125>
WebKit Commit Bot
Comment 7 2018-10-15 10:27:11 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.