Bug 190540

Summary: Shrink more enum classes
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch cdumez: review+

Alex Christensen
Reported 2018-10-12 14:47:49 PDT
Shrink more enum classes
Attachments
Patch (50.34 KB, patch)
2018-10-12 14:50 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (51.77 KB, patch)
2018-10-12 14:55 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (52.23 KB, patch)
2018-10-12 15:28 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (57.91 KB, patch)
2018-10-12 15:51 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (58.38 KB, patch)
2018-10-12 16:04 PDT, Alex Christensen 		cdumez: review+
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2018-10-12 14:50:16 PDT
Created attachment 352207 [details] Patch
Alex Christensen
Comment 2 2018-10-12 14:55:39 PDT
Created attachment 352209 [details] Patch
Alex Christensen
Comment 3 2018-10-12 15:28:44 PDT
Created attachment 352218 [details] Patch
Alex Christensen
Comment 4 2018-10-12 15:51:03 PDT
Created attachment 352221 [details] Patch
Alex Christensen
Comment 5 2018-10-12 16:04:57 PDT
Created attachment 352224 [details] Patch
Chris Dumez
Comment 6 2018-10-12 17:27:01 PDT
Comment on attachment 352224 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352224&action=review r=me with comment. > Source/WebCore/loader/ShouldSkipSafeBrowsingCheck.h:32 > +enum class ShouldSkipSafeBrowsingCheck : uint8_t { No, Yes }; Why aren't we using : bool here? > Source/WebCore/loader/ShouldTreatAsContinuingLoad.h:32 > +enum class ShouldTreatAsContinuingLoad : uint8_t { No, Yes }; ditto. > Source/WebCore/page/DiagnosticLoggingClient.h:35 > +enum class ShouldSample : uint8_t { No, Yes }; ditto. > Source/WebCore/platform/CookiesStrategy.h:40 > +enum class IncludeSecureCookies : uint8_t { No, Yes }; ditto. > Source/WebCore/platform/network/StoredCredentialsPolicy.h:30 > +enum class StoredCredentialsPolicy : uint8_t { ditto. > Source/WebCore/workers/service/ServiceWorkerTypes.h:63 > +enum class ShouldNotifyWhenResolved : uint8_t { No, Yes }; ditto. > Source/WebKit/Shared/UndoOrRedo.h:32 > +enum class UndoOrRedo : uint8_t { Undo, Redo }; ditto. > Source/WebKit/WebProcess/UserContent/InjectUserScriptImmediately.h:32 > +enum class InjectUserScriptImmediately : uint8_t { No, Yes }; ditto.
Alex Christensen
Comment 7 2018-10-15 08:24:12 PDT
http://trac.webkit.org/r237110
Radar WebKit Bug Importer
Comment 8 2018-10-15 08:25:38 PDT
<rdar://problem/45271669>
Note You need to log in before you can comment on or make changes to this bug.