Bug 190538 – Web Inspector: Cleanup Table test utilities

• Component: Web Inspector
• Status: RESOLVED FIXED

[Matt Baker]

Creating Table instances for tests is pretty inflexible. For example, providing a custom delegate for a test without providing a custom data source is awkward, given that:

    InspectorTest.createTable = function(delegate, dataSource) {...}

The order of these arguments was partly because of an artificial dependency between TableDelegate and TableDataSource (constructing a TableDelegate requires that the data source exist, so that the delegate can access its `items` property). This dependency should be removed, and the utility methods exposed to InspectorTest simplified.

[Radar WebKit Bug Importer]

<rdar://problem/45237730>

[Matt Baker]

Created attachment 352205 [details]
Patch

[Matt Baker]

Created attachment 352208 [details]
Patch

[Matt Baker]

Created attachment 352216 [details]
Patch

[Matt Baker]

(In reply to Matt Baker from comment #4)
> Created attachment 352216 [details]
> Patch

Removed unnecessary closure.

[Joseph Pecoraro]

Comment on attachment 352216 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 352216 [details]
Patch

Rejecting attachment 352216 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 352216, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=352216&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=190538&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Updating working directory
Processing patch 352216 from bug 190538.
Fetching: https://bugs.webkit.org/attachment.cgi?id=352216
Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	M	LayoutTests/inspector/table/resources/table-utilities.js
	M	LayoutTests/inspector/table/table-selection-expected.txt
	M	LayoutTests/inspector/table/table-selection.html

ERROR from SVN:
A repository hook failed: Commit blocked by pre-commit hook (exit code 1) with output:
Commits are currently disabled while we update infrastructure.
W: 7524034ce8226809e8cfdcd66f20b506fdfeadbc and refs/remotes/origin/master differ, using rebase:
:040000 040000 09d9ef5a4dd8bf66fa3034a72926254b40918d8b 92eda367eb67787361b8f4da2a96959390505aa7 M	LayoutTests
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	M	LayoutTests/inspector/table/resources/table-utilities.js
	M	LayoutTests/inspector/table/table-selection-expected.txt
	M	LayoutTests/inspector/table/table-selection.html

ERROR from SVN:
A repository hook failed: Commit blocked by pre-commit hook (exit code 1) with output:
Commits are currently disabled while we update infrastructure.
W: 7524034ce8226809e8cfdcd66f20b506fdfeadbc and refs/remotes/origin/master differ, using rebase:
:040000 040000 09d9ef5a4dd8bf66fa3034a72926254b40918d8b 92eda367eb67787361b8f4da2a96959390505aa7 M	LayoutTests
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
From https://git.webkit.org/git/WebKit
   eaa251f4427..2fde85661b4  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 237089 = eaa251f4427efa277b980c9fd8a09482dcfe0f06
r237090 = c0de3e0d64fefa6d1ffab293dcbe3fe23a87a49c
r237091 = 2fde85661b4bf2a3ad6344694401d91e9220e99e
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: https://webkit-queues.webkit.org/results/9559620

[Joseph Pecoraro]

Maybe this needs to land manually or be rebased.

[Matt Baker]

Created attachment 352396 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 352396 [details]
Patch for landing

Clearing flags on attachment: 352396

Committed r237155: <https://trac.webkit.org/changeset/237155>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.