| Summary: | Web Inspector: sequences of spaces longer than 16 don't show a dot | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||||
| Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, inspector-bugzilla-changes, joepeck, mattbaker, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 352245 [details]
Patch
Comment on attachment 352245 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352245&action=review r=me, nice cleanup! > Source/WebInspectorUI/UserInterface/Views/CodeMirrorAdditions.js:369 > + styleText += `content: "${"\\00B7".repeat(count)}";`; Nit: I think '\\00B7' would make this a little easier to read, since the "outer" double-quotes are part of the string, and the "inner" double-quotes are part of the expression. Comment on attachment 352245 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352245&action=review > Source/WebInspectorUI/UserInterface/Views/CodeMirrorAdditions.js:372 > + whitespaceStyleElement.textContent = styleText; Hmm, this looks like the browser would have to reparse the entire stylesheet every time a new value is added, which seems wasteful. Maybe just creating a new element might be more efficient. Or maybe this is just negligible. Comment on attachment 352245 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352245&action=review >> Source/WebInspectorUI/UserInterface/Views/CodeMirrorAdditions.js:372 >> + whitespaceStyleElement.textContent = styleText; > > Hmm, this looks like the browser would have to reparse the entire stylesheet every time a new value is added, which seems wasteful. Maybe just creating a new element might be more efficient. Or maybe this is just negligible. This only happens each time we encounter a new number of sequential spaces. In my experience, I haven't seen more than 32 in a row before. I don't think this is something we need to worry about. Created attachment 352460 [details]
Patch
Comment on attachment 352460 [details] Patch Clearing flags on attachment: 352460 Committed r237186: <https://trac.webkit.org/changeset/237186> All reviewed patches have been landed. Closing bug. |
Created attachment 352181 [details] [Image] Screenshot of Issue We should probably programmatically generate the CSS space rules instead of manually writing 16 of them.