Bug 190512

Summary: [WebAssembly] I64 arguments / return value check should be moved from callWebAssemblyFunction to JSToWasm wrapper
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, rniwa, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from ews107 for mac-sierra-wk2
none
Patch
none
Patch
none
Patch
none
Patch keith_miller: review+

Yusuke Suzuki
Reported 2018-10-11 22:38:05 PDT
[WebAssembly] I64 arguments / return value check should be moved from callWebAssemblyFunction to JSToWasm wrapper
Attachments
Patch (10.93 KB, patch)
2018-10-11 22:53 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (10.92 KB, patch)
2018-10-11 23:31 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews107 for mac-sierra-wk2 (3.41 MB, application/zip)
2018-10-12 00:34 PDT, EWS Watchlist 		no flags
Details
Patch (11.06 KB, patch)
2018-10-12 07:11 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (10.54 KB, patch)
2018-10-12 09:12 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (10.91 KB, patch)
2018-11-01 06:21 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (9.97 KB, patch)
2018-11-01 08:06 PDT, Yusuke Suzuki 		keith_miller: review+
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2018-10-11 22:53:01 PDT
Created attachment 352139 [details] Patch
Yusuke Suzuki
Comment 2 2018-10-11 23:27:38 PDT
The goal of this is eliminating callWebAssemblyFunction, making the current wrapper the same to JS JITCode entry, calling wasm code smoothly from the rest of the world.
Yusuke Suzuki
Comment 3 2018-10-11 23:31:41 PDT
Created attachment 352142 [details] Patch
EWS Watchlist
Comment 4 2018-10-12 00:34:54 PDT
Comment on attachment 352142 [details] Patch Attachment 352142 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9548028 New failing tests: css3/filters/backdrop/add-remove-add-backdrop-filter.html
EWS Watchlist
Comment 5 2018-10-12 00:34:56 PDT
Created attachment 352149 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
EWS Watchlist
Comment 6 2018-10-12 01:00:42 PDT
Comment on attachment 352142 [details] Patch Attachment 352142 [details] did not pass jsc-ews (mac): Output: https://webkit-queues.webkit.org/results/9548138 New failing tests: wasm.yaml/wasm/function-tests/i64-from-js-exceptions.js.wasm-no-cjit-yes-tls-context wasm.yaml/wasm/function-tests/function-import-return-value.js.wasm-no-cjit-yes-tls-context wasm.yaml/wasm/function-tests/i64-from-js-exceptions.js.wasm-no-call-ic wasm.yaml/wasm/function-tests/function-import-return-value.js.wasm-slow-memory wasm.yaml/wasm/function-tests/function-import-return-value.js.default-wasm wasm.yaml/wasm/function-tests/i64-from-js-exceptions.js.wasm-eager-jettison wasm.yaml/wasm/function-tests/function-import-return-value.js.wasm-no-tls-context wasm.yaml/wasm/function-tests/i64-from-js-exceptions.js.wasm-no-tls-context wasm.yaml/wasm/function-tests/function-import-return-value.js.wasm-no-call-ic wasm.yaml/wasm/function-tests/i64-from-js-exceptions.js.default-wasm wasm.yaml/wasm/function-tests/i64-from-js-exceptions.js.wasm-slow-memory wasm.yaml/wasm/function-tests/function-import-return-value.js.wasm-eager-jettison apiTests
Yusuke Suzuki
Comment 7 2018-10-12 07:11:57 PDT
Created attachment 352166 [details] Patch
EWS Watchlist
Comment 8 2018-10-12 08:45:03 PDT
Comment on attachment 352166 [details] Patch Attachment 352166 [details] did not pass jsc-ews (mac): Output: https://webkit-queues.webkit.org/results/9551414 New failing tests: wasm.yaml/wasm/function-tests/i64-from-js-exceptions.js.wasm-no-cjit-yes-tls-context wasm.yaml/wasm/function-tests/function-import-return-value.js.wasm-no-cjit-yes-tls-context wasm.yaml/wasm/function-tests/i64-from-js-exceptions.js.wasm-no-call-ic wasm.yaml/wasm/function-tests/function-import-return-value.js.wasm-slow-memory wasm.yaml/wasm/function-tests/function-import-return-value.js.default-wasm wasm.yaml/wasm/function-tests/i64-from-js-exceptions.js.wasm-eager-jettison wasm.yaml/wasm/function-tests/function-import-return-value.js.wasm-no-tls-context wasm.yaml/wasm/function-tests/i64-from-js-exceptions.js.wasm-no-tls-context wasm.yaml/wasm/function-tests/function-import-return-value.js.wasm-no-call-ic wasm.yaml/wasm/function-tests/i64-from-js-exceptions.js.default-wasm wasm.yaml/wasm/function-tests/i64-from-js-exceptions.js.wasm-slow-memory wasm.yaml/wasm/function-tests/function-import-return-value.js.wasm-eager-jettison apiTests
Yusuke Suzuki
Comment 9 2018-10-12 09:12:58 PDT
Created attachment 352171 [details] Patch
Yusuke Suzuki
Comment 10 2018-11-01 06:21:19 PDT
Created attachment 353594 [details] Patch
Yusuke Suzuki
Comment 11 2018-11-01 08:06:22 PDT
Created attachment 353600 [details] Patch
Yusuke Suzuki
Comment 12 2018-11-11 23:58:55 PST
Ping?
Yusuke Suzuki
Comment 13 2018-11-18 22:52:07 PST
Ping?
Keith Miller
Comment 14 2018-11-19 08:42:59 PST
Comment on attachment 353600 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353600&action=review > Source/JavaScriptCore/wasm/js/WebAssemblyFunction.cpp:84 > + arg = JSValue::decode(0); Nit I think you can just do: arg = JSValue()
Yusuke Suzuki
Comment 15 2018-11-19 08:48:05 PST
Comment on attachment 353600 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353600&action=review >> Source/JavaScriptCore/wasm/js/WebAssemblyFunction.cpp:84 >> + arg = JSValue::decode(0); > > Nit I think you can just do: > > arg = JSValue() Nice, fixed.
Yusuke Suzuki
Comment 16 2018-11-19 08:49:48 PST
Committed r238376: <https://trac.webkit.org/changeset/238376>
Radar WebKit Bug Importer
Comment 17 2018-11-19 08:50:58 PST
<rdar://problem/46169779>
Note You need to log in before you can comment on or make changes to this bug.