Bug 190459

Summary:

Remove InjectedBundle processing of back/forward lists

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, dbates, ews-watchlist, japhet, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Archive of layout-test-results from ews106 for mac-sierra-wk2	none
Archive of layout-test-results from ews121 for ios-simulator-wk2	none
Patch	none
Patch	cdumez: review+

Alex Christensen

Reported 2018-10-10 21:57:26 PDT

Remove InjectedBundle processing of back/forward lists

Attachments
Patch (57.53 KB, patch) 2018-10-10 22:02 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (57.56 KB, patch) 2018-10-11 08:33 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews106 for mac-sierra-wk2 (2.08 MB, application/zip) 2018-10-11 09:37 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (689.46 KB, application/zip) 2018-10-11 14:26 PDT, EWS Watchlist	no flags	Details
Patch (26.52 KB, patch) 2018-10-11 16:47 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (26.36 KB, patch) 2018-10-11 17:06 PDT, Alex Christensen	cdumez: review+	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Alex Christensen

Comment 1 2018-10-10 22:02:04 PDT

Created attachment 352015 [details] Patch

EWS Watchlist

Comment 2 2018-10-10 22:04:09 PDT

Attachment 352015 [details] did not pass style-queue: ERROR: Source/WebCore/loader/EmptyFrameLoaderClient.h:168: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 1 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.

Alex Christensen

Comment 3 2018-10-11 08:33:39 PDT

Created attachment 352045 [details] Patch

EWS Watchlist

Comment 4 2018-10-11 08:36:18 PDT

Attachment 352045 [details] did not pass style-queue: ERROR: Source/WebCore/loader/EmptyFrameLoaderClient.h:168: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 1 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.

EWS Watchlist

Comment 5 2018-10-11 09:37:56 PDT

Comment on attachment 352045 [details] Patch Attachment 352045 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9536756 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 6 2018-10-11 09:37:58 PDT

Created attachment 352049 [details] Archive of layout-test-results from ews106 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 7 2018-10-11 14:26:11 PDT

Comment on attachment 352045 [details] Patch Attachment 352045 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9540231 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 8 2018-10-11 14:26:12 PDT

Created attachment 352078 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6

Alex Christensen

Comment 9 2018-10-11 16:47:35 PDT

Created attachment 352103 [details] Patch

EWS Watchlist

Comment 10 2018-10-11 16:49:20 PDT

Attachment 352103 [details] did not pass style-queue: ERROR: Source/WebCore/loader/EmptyFrameLoaderClient.h:168: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 1 in 25 files If any of these errors are false positives, please file a bug against check-webkit-style.

Alex Christensen

Comment 11 2018-10-11 17:06:35 PDT

Created attachment 352106 [details] Patch

EWS Watchlist

Comment 12 2018-10-11 17:09:58 PDT

Attachment 352106 [details] did not pass style-queue: ERROR: Source/WebCore/loader/EmptyFrameLoaderClient.h:168: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 1 in 25 files If any of these errors are false positives, please file a bug against check-webkit-style.

Alex Christensen

Comment 13 2018-10-15 08:25:09 PDT

https://trac.webkit.org/changeset/237102/webkit

Radar WebKit Bug Importer

Comment 14 2018-10-15 08:26:37 PDT

<rdar://problem/45271694>

Alex Christensen

Comment 15 2018-10-15 08:29:58 PDT

http://trac.webkit.org/r237111

Note You need to log in before you can comment on or make changes to this bug.