Bug 190452 – [WHSL -> MSL] Annotate semantics correctly in generated MSL

• Component: New Bugs
• Status: RESOLVED FIXED

[Dean Jackson]

[WHSL -> MSL] Annotate semantics correctly in generated MSL

[Radar WebKit Bug Importer]

<rdar://problem/45178272>

[Dean Jackson]

Created attachment 352000 [details]
Patch

[Myles C. Maxfield]

Comment on attachment 352000 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352000&action=review

> Tools/WebGPUShadingLanguageRI/Metal/MSLBackend.js:338
>              if (structTypeAttributes.isVertexAttribute)
> -                annotations.push(`attribute(${index++})`);
> -            if (structTypeAttributes.isVertexOutputOrFragmentInput && fieldName === "wsl_Position")
> +                annotations.push(`attribute(${field._semantic._index})`);
> +            if (structTypeAttributes.isVertexOutputOrFragmentInput && field._semantic._name === "SV_Position")
>                  annotations.push("position");
> -            if (structTypeAttributes.isFragmentOutput && fieldName === "wsl_Color")
> -                annotations.push("color(0)");
> +            if (structTypeAttributes.isFragmentOutput && field._semantic._name == "SV_Target")
> +                annotations.push(`color(${field._semantic._extraArguments[0]})`);

Eventually we're going to need this to get much more complicated, but this is a good start.

[Dean Jackson]

Committed r237022: <https://trac.webkit.org/changeset/237022>