Bug 190381

Summary: Web Inspector: create icons for media event types instead of using a blue circle
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, hi, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 189773    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
[Image] After Patch is applied none

Devin Rousso
Reported 2018-10-08 16:39:49 PDT
The blue circle, while indicative of timing, doesn't do any benefit at a cursory glance as to what happened. For events that have obvious iconography (e.g. play ▶️, pause ⏸, stalled [...] (like an ellipsis in a box), ended ⏹), we should attempt to use those icons. This will require some logic to decide what icon is most important (e.g. when multiple events occur at the same time), but it should make looking at the timeline much more useful.
Attachments
Patch (11.16 KB, patch)
2019-01-18 17:14 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
[Image] After Patch is applied (1005.10 KB, image/png)
2019-01-18 17:14 PST, Devin Rousso 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-10-23 19:02:30 PDT
<rdar://problem/45507995>
Devin Rousso
Comment 2 2019-01-18 17:14:09 PST
Created attachment 359560 [details] Patch
Devin Rousso
Comment 3 2019-01-18 17:14:26 PST
Created attachment 359561 [details] [Image] After Patch is applied
Blaze Burg
Comment 4 2019-02-01 14:49:19 PST
Comment on attachment 359560 [details] Patch r=me The ... is not the best icon, but I suppose it catches attention. I would prefer a broken pipe icon. =/=
WebKit Commit Bot
Comment 5 2019-02-01 15:29:41 PST
Comment on attachment 359560 [details] Patch Clearing flags on attachment: 359560 Committed r240884: <https://trac.webkit.org/changeset/240884>
WebKit Commit Bot
Comment 6 2019-02-01 15:29:43 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.