Bug 190378 – PSON: Doing a cross-site navigation via the URL bar does not swap process on iOS

• Component: WebKit2
• Status: RESOLVED FIXED

[Chris Dumez]

Doing a cross-site navigation via the URL bar does not swap process on iOS, even though PSON is enabled.

[Chris Dumez]

<rdar://problem/45059466>

[Chris Dumez]

Created attachment 351830 [details]
Patch

[Alex Christensen]

Comment on attachment 351830 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351830&action=review

> Source/WebKit/ChangeLog:10
> +        which would use a new WebView for the speculative load and rely on the _relatedWebView SPI to use

WKWebView

> Source/WebKit/UIProcess/WebProcessPool.cpp:2147
> +            url = URL { { }, page.configuration().relatedPage()->pageLoadState().url() };

I feel like url needs a more descriptive name.  sourceURL?

> Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:1852
> +    auto processPoolConfiguration = adoptNS([[_WKProcessPoolConfiguration alloc] init]);

These two tests should share some code.

[Chris Dumez]

Created attachment 351897 [details]
Patch

[Geoffrey Garen]

Comment on attachment 351897 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 351897 [details]
Patch

Clearing flags on attachment: 351897

Committed r236973: <https://trac.webkit.org/changeset/236973>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.