Bug 190368

Summary: ISOTrackEncryptionBox returns incorrect defaultKeyID
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 190374    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Description Jer Noble 2018-10-08 12:40:24 PDT 
ISOTrackEncryptionBox returns incorrect defaultKeyID
Comment 1 Radar WebKit Bug Importer 2018-10-08 12:44:15 PDT 
<rdar://problem/45100137>
Comment 2 Jer Noble 2018-10-08 12:46:11 PDT 
Created attachment 351803 [details]
Patch
Comment 3 Jer Noble 2018-10-08 12:48:20 PDT 
Created attachment 351805 [details]
Patch
Comment 4 EWS Watchlist 2018-10-08 12:52:00 PDT 
Attachment 351805 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/iso/ISOProtectionSchemeInfoBox.h:39:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Jer Noble 2018-10-08 13:46:08 PDT 
Comment on attachment 351805 [details]
Patch

WinCairo failure appears to be a "permission denied" error. Landing.
Comment 6 WebKit Commit Bot 2018-10-08 14:12:20 PDT 
Comment on attachment 351805 [details]
Patch

Clearing flags on attachment: 351805

Committed r236941: <https://trac.webkit.org/changeset/236941>
Comment 7 WebKit Commit Bot 2018-10-08 14:12:22 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 WebKit Commit Bot 2018-10-08 15:22:00 PDT 
Re-opened since this is blocked by bug 190374
Comment 9 Jer Noble 2018-10-08 15:50:58 PDT 
Created attachment 351825 [details]
Patch for landing
Comment 10 EWS Watchlist 2018-10-08 15:53:24 PDT 
Attachment 351825 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/iso/ISOProtectionSchemeInfoBox.h:39:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 1 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 11 WebKit Commit Bot 2018-10-09 09:54:39 PDT 
Comment on attachment 351825 [details]
Patch for landing

Clearing flags on attachment: 351825

Committed r236964: <https://trac.webkit.org/changeset/236964>
Comment 12 WebKit Commit Bot 2018-10-09 09:54:41 PDT 
All reviewed patches have been landed.  Closing bug.