Bug 190348

Summary:

Move FontCascadeDescription to a file of its own

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

Text

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, ews-watchlist, ggaren, mmaxfield, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none
patch	none
patch	none

Antti Koivisto

Reported 2018-10-08 06:43:39 PDT

From FontDescription

Attachments
patch (75.72 KB, patch) 2018-10-08 06:51 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (77.63 KB, patch) 2018-10-08 07:30 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (78.14 KB, patch) 2018-10-08 07:34 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Antti Koivisto

Comment 1 2018-10-08 06:51:31 PDT

Created attachment 351773 [details] patch

EWS Watchlist

Comment 2 2018-10-08 06:53:57 PDT

Attachment 351773 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/FontCascadeDescription.h:140: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/graphics/FontCascadeDescription.h:141: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/FontCascadeDescription.h:143: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/FontCascadeDescription.h:146: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WebCore/platform/graphics/FontCascadeDescription.h:147: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/FontCascadeDescription.h:148: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WebCore/platform/graphics/FontCascadeDescription.h:148: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 7 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.

Antti Koivisto

Comment 3 2018-10-08 07:30:40 PDT

Created attachment 351775 [details] patch

EWS Watchlist

Comment 4 2018-10-08 07:32:18 PDT

Attachment 351775 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/FontCascadeDescription.h:145: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WebCore/platform/graphics/FontCascadeDescription.h:147: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Total errors found: 2 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.

Antti Koivisto

Comment 5 2018-10-08 07:34:38 PDT

Created attachment 351776 [details] patch

Chris Dumez

Comment 6 2018-10-08 07:53:07 PDT

Comment on attachment 351776 [details] patch rs=me

WebKit Commit Bot

Comment 7 2018-10-08 09:09:36 PDT

Comment on attachment 351776 [details] patch Clearing flags on attachment: 351776 Committed r236914: <https://trac.webkit.org/changeset/236914>

WebKit Commit Bot

Comment 8 2018-10-08 09:09:38 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 9 2018-10-08 09:10:35 PDT

<rdar://problem/45089920>

Note You need to log in before you can comment on or make changes to this bug.