Bug 190348

Summary: Move FontCascadeDescription to a file of its own
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: TextAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, ews-watchlist, ggaren, mmaxfield, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch
none
patch none

Description Antti Koivisto 2018-10-08 06:43:39 PDT
From FontDescription
Comment 1 Antti Koivisto 2018-10-08 06:51:31 PDT
Created attachment 351773 [details]
patch
Comment 2 EWS Watchlist 2018-10-08 06:53:57 PDT
Attachment 351773 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/FontCascadeDescription.h:140:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/graphics/FontCascadeDescription.h:141:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/FontCascadeDescription.h:143:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/FontCascadeDescription.h:146:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/graphics/FontCascadeDescription.h:147:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/FontCascadeDescription.h:148:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/graphics/FontCascadeDescription.h:148:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 7 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Antti Koivisto 2018-10-08 07:30:40 PDT
Created attachment 351775 [details]
patch
Comment 4 EWS Watchlist 2018-10-08 07:32:18 PDT
Attachment 351775 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/FontCascadeDescription.h:145:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/graphics/FontCascadeDescription.h:147:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 2 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Antti Koivisto 2018-10-08 07:34:38 PDT
Created attachment 351776 [details]
patch
Comment 6 Chris Dumez 2018-10-08 07:53:07 PDT
Comment on attachment 351776 [details]
patch

rs=me
Comment 7 WebKit Commit Bot 2018-10-08 09:09:36 PDT
Comment on attachment 351776 [details]
patch

Clearing flags on attachment: 351776

Committed r236914: <https://trac.webkit.org/changeset/236914>
Comment 8 WebKit Commit Bot 2018-10-08 09:09:38 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2018-10-08 09:10:35 PDT
<rdar://problem/45089920>