Bug 190315

Summary: Enable WKPreferences._lowPowerVideoAudioBufferSizeEnabled by default
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, ews-watchlist, jeffm, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews104 for mac-sierra-wk2
none
Patch none

Description Jer Noble 2018-10-05 11:02:21 PDT
Enable WKPreferences._lowPowerVideoAudioBufferSizeEnabled by default
Comment 1 Jer Noble 2018-10-05 11:06:29 PDT
Created attachment 351681 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2018-10-05 11:08:36 PDT
<rdar://problem/45047807>
Comment 3 Eric Carlson 2018-10-05 11:26:59 PDT
Comment on attachment 351681 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351681&action=review

> Source/WebKit/ChangeLog:8
> +        This preference is disabled for WebKitLegacy because it can interact poorly with clients own use of audio.

Nit: clients => client's
Comment 4 EWS Watchlist 2018-10-05 12:20:24 PDT
Comment on attachment 351681 [details]
Patch

Attachment 351681 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9464833

New failing tests:
media/audio-controls-timeline-in-media-document.html
Comment 5 EWS Watchlist 2018-10-05 12:20:26 PDT
Created attachment 351687 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 6 Jer Noble 2018-10-18 14:08:34 PDT
Created attachment 352730 [details]
Patch
Comment 7 WebKit Commit Bot 2018-10-18 16:01:51 PDT
Comment on attachment 352730 [details]
Patch

Clearing flags on attachment: 352730

Committed r237273: <https://trac.webkit.org/changeset/237273>
Comment 8 WebKit Commit Bot 2018-10-18 16:01:53 PDT
All reviewed patches have been landed.  Closing bug.