Summary: | Validation in Connection::readBytesFromSocket() is too aggressive | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Konstantin Tokarev <annulen> | ||||
Component: | Platform | Assignee: | Konstantin Tokarev <annulen> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | cgarcia, commit-queue, mcatanzaro, webkit-bug-importer, zan | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=171871 | ||||||
Attachments: |
|
Description
Konstantin Tokarev
2018-10-04 10:06:03 PDT
Created attachment 351598 [details]
Patch
Comment on attachment 351598 [details] Patch Oh wow, good find. Under what scenario were you hitting this failure? Any way to write a test? Can you add it to https://trac.webkit.org/wiki/WebKitGTK/2.22.x (for 2.22.3) after landing, please? (In reply to Michael Catanzaro from comment #2) > Comment on attachment 351598 [details] > Patch > > Oh wow, good find. > > Under what scenario were you hitting this failure? It was reproducing with QtWebKit, but not with GTK port. I guess behavior is different because Qt uses UI-side compositing, which is probably a reson why there are so many attachments. >Any way to write a test? No idea from the top of my had. > > Can you add it to https://trac.webkit.org/wiki/WebKitGTK/2.22.x (for 2.22.3) > after landing, please? Sure Comment on attachment 351598 [details] Patch Clearing flags on attachment: 351598 Committed r236928: <https://trac.webkit.org/changeset/236928> All reviewed patches have been landed. Closing bug. |