Bug 190266 – Add support for reporting "display composited video frames" through the VideoPlaybackQuality object.

• Component: New Bugs
• Status: RESOLVED FIXED

[Jer Noble]

Add support for reporting "display composited video frames" through the VideoPlaybackQuality object.

[Jer Noble]

Created attachment 351554 [details]
Patch

[Jer Noble]

Created attachment 351565 [details]
Patch

[Jer Noble]

Created attachment 351566 [details]
Patch

[Jer Noble]

Created attachment 351568 [details]
Patch

[Eric Carlson]

Comment on attachment 351568 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351568&action=review

r=me once the bots are happy

> Source/WebCore/Modules/mediasource/VideoPlaybackQuality.h:38
> +    static Ref<VideoPlaybackQuality> create(double creationTime, const VideoPlaybackQualityMetrics&);

VideoPlaybackQualityMetrics&& ?

> Source/WebCore/Modules/mediasource/VideoPlaybackQuality.h:48
> +    VideoPlaybackQuality(double creationTime, const VideoPlaybackQualityMetrics&);

Ditto

[Jer Noble]

(In reply to Eric Carlson from comment #5)
> Comment on attachment 351568 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=351568&action=review
> 
> r=me once the bots are happy
> 
> > Source/WebCore/Modules/mediasource/VideoPlaybackQuality.h:38
> > +    static Ref<VideoPlaybackQuality> create(double creationTime, const VideoPlaybackQualityMetrics&);
> 
> VideoPlaybackQualityMetrics&& ?
> 
> > Source/WebCore/Modules/mediasource/VideoPlaybackQuality.h:48
> > +    VideoPlaybackQuality(double creationTime, const VideoPlaybackQualityMetrics&);
> 
> Ditto

This would imply that the VideoPlaybackQuality object was taking these values directly from the passed in struct. That might make sense if we were literally storing those values in an VideoPlaybackQualityMetrics ivar, but we only using the values themselves.

[Jer Noble]

Created attachment 351600 [details]
Patch for landing

[Jer Noble]

Created attachment 351606 [details]
Patch for landing

[Jer Noble]

Created attachment 351608 [details]
Patch for landing

[Jer Noble]

Created attachment 351609 [details]
Patch for landing

[Jer Noble]

Created attachment 351610 [details]
Patch for landing

[Jer Noble]

<rdar://problem/43948647>

[EWS Watchlist]

Comment on attachment 351610 [details]
Patch for landing

Attachment 351610 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/9454732

New failing tests:
media/media-source/media-source-video-playback-quality.html
media/media-source/media-source-append-nonsync-sample-after-abort.html

[EWS Watchlist]

Created attachment 351616 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 351610 [details]
Patch for landing

Attachment 351610 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9454759

New failing tests:
media/media-source/media-source-video-playback-quality.html
media/media-source/media-source-append-nonsync-sample-after-abort.html

[EWS Watchlist]

Created attachment 351619 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 351610 [details]
Patch for landing

Attachment 351610 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/9454767

New failing tests:
media/media-source/media-source-video-playback-quality.html
media/media-source/media-source-append-nonsync-sample-after-abort.html

[EWS Watchlist]

Created attachment 351627 [details]
Archive of layout-test-results from ews117 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Jer Noble]

Created attachment 351633 [details]
Patch for landing

[Jer Noble]

Created attachment 351640 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 351640 [details]
Patch for landing

Clearing flags on attachment: 351640

Committed r236866: <https://trac.webkit.org/changeset/236866>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Antoine Quint]

My debug build failed because of this commit:

In file included from /Users/antoine/Code/safari/OpenSource/Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:38:
PAL/pal/spi/mac/AVFoundationSPI.h:191:4: error: expected a type
- (AVVideoPerformanceMetrics *)videoPerformanceMetrics;
   ^
PAL/pal/spi/mac/AVFoundationSPI.h:191:1: error: method has no return type specified; defaults to 'id' [-Werror,-Wmissing-method-return-type]
- (AVVideoPerformanceMetrics *)videoPerformanceMetrics;
^
2 errors generated.

[Chris Dumez]

(In reply to Antoine Quint from comment #23)
> My debug build failed because of this commit:
> 
> In file included from
> /Users/antoine/Code/safari/OpenSource/Source/WebCore/platform/graphics/
> avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:38:
> PAL/pal/spi/mac/AVFoundationSPI.h:191:4: error: expected a type
> - (AVVideoPerformanceMetrics *)videoPerformanceMetrics;
>    ^
> PAL/pal/spi/mac/AVFoundationSPI.h:191:1: error: method has no return type
> specified; defaults to 'id' [-Werror,-Wmissing-method-return-type]
> - (AVVideoPerformanceMetrics *)videoPerformanceMetrics;
> ^
> 2 errors generated.

Same here.

[Ryan Haddad]

Reverted r236866 for reason:

Breaks internal builds.

Committed r236874: <https://trac.webkit.org/changeset/236874>

[Jer Noble]

Committed r236875: <https://trac.webkit.org/changeset/236875>

[Jer Noble]

Committed build fix in r236876: <https://trac.webkit.org/changeset/236876>