Bug 190263

Summary: Suppress unreachable code warning for LLIntAssembly.h code.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch. saam: review+

Mark Lam
Reported 2018-10-03 14:53:25 PDT
This is needed because LLIntAssembly.h is template generated from LowLevelInterpreter asm files, and may contain dead code which are harmless, but will trip up the warning. We should suppress the warning so that it doesn't break builds. <rdar://problem/44986532>
Attachments
proposed patch. (1.57 KB, patch)
2018-10-03 14:58 PDT, Mark Lam 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2018-10-03 14:58:34 PDT
Created attachment 351549 [details] proposed patch.
Mark Lam
Comment 2 2018-10-03 15:03:21 PDT
Thanks for the review. Landed in r236813: <http://trac.webkit.org/r236813>.
Note You need to log in before you can comment on or make changes to this bug.