| Summary: | [Xcode] Update some build settings as recommended by Xcode 10 | ||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | mitz | ||||||||||||||||||||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||||
| Severity: | Normal | CC: | aboxhall, achristensen, aestes, andersca, apinheiro, benjamin, cdumez, cfleizach, cmarcelo, dbates, dino, dmazzoni, eric.carlson, ews-watchlist, graouts, japhet, jcraig, jdiggs, keith_miller, kondapallykalyan, lforschler, mark.lam, msaboff, ryanhaddad, saam, samuel_white, sam, thorton, webkit-bug-importer | ||||||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||||
| Version: | Safari Technology Preview | ||||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||
|
Description
mitz
2018-10-03 09:28:08 PDT
Created attachment 351527 [details]
bmalloc, WTF and JavaScriptCore parts
Attachment 351527 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/assembler/MacroAssemblerPrinter.cpp:56: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/JavaScriptCore/assembler/MacroAssemblerPrinter.cpp:66: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/JavaScriptCore/assembler/MacroAssemblerPrinter.cpp:70: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/JavaScriptCore/assembler/MacroAssemblerPrinter.cpp:77: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/JavaScriptCore/assembler/MacroAssemblerPrinter.cpp:80: More than one command on the same line [whitespace/newline] [4]
Total errors found: 5 in 13 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Committed attachment 351527 [details] as <https://trac.webkit.org/r236805>. Created attachment 351545 [details]
ANGLE and libwebrtc parts
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE Committed attachment 351545 [details] as <https://trac.webkit.org/r236811>. Created attachment 351556 [details]
WebCore and PAL parts
Attachment 351556 [details] did not pass style-queue:
ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 1 in 9 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 351558 [details]
WebCore and PAL parts
Created attachment 351589 [details]
WebInspectorUI and WebKitLegacy parts
Attachment 351589 [details] did not pass style-queue:
ERROR: Source/WebKitLegacy/mac/WebView/WebJSPDFDoc.mm:30: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WebKitLegacy/mac/WebView/WebView.mm:7358: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
ERROR: Source/WebKitLegacy/mac/WebView/WebView.mm:7380: The parameter name "preferences" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/WebKitLegacy/mac/WebView/WebView.mm:7439: Should have a space between // and comment [whitespace/comments] [4]
ERROR: Source/WebKitLegacy/mac/WebView/WebView.mm:7462: One line control clauses should not use braces. [whitespace/braces] [4]
ERROR: Source/WebKitLegacy/mac/WebView/WebView.mm:7464: One line control clauses should not use braces. [whitespace/braces] [4]
ERROR: Source/WebKitLegacy/mac/WebView/WebView.mm:7475: One line control clauses should not use braces. [whitespace/braces] [4]
ERROR: Source/WebKitLegacy/mac/WebView/WebDeviceOrientationProviderMock.mm:115: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:1374: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3]
Total errors found: 9 in 32 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 351589 [details]
WebInspectorUI and WebKitLegacy parts
I guess this one needs more work for 32-bit macOS and for iOS.
Committed attachment 351558 [details] as <https://trac.webkit.org/r236832>. Committed attachment 351589 [details] with fixes for 32-bit macOS and iOS as <https://trac.webkit.org/r236846>. Created attachment 351652 [details]
WebKit part
Created attachment 351731 [details]
WebKit part
Created attachment 351732 [details]
WebKit part
Created attachment 351733 [details]
WebKit part
Committed attachment 351733 [details] as <https://trac.webkit.org/r236902>. (In reply to mitz from comment #19) > Committed attachment 351733 [details] as <https://trac.webkit.org/r236902>. This appears to have broken the Mojave build: https://build.webkit.org/builders/Apple%20Mojave%20Debug%20%28Build%29/builds/193 (In reply to Ryan Haddad from comment #20) > (In reply to mitz from comment #19) > > Committed attachment 351733 [details] as <https://trac.webkit.org/r236902>. > This appears to have broken the Mojave build: > https://build.webkit.org/builders/Apple%20Mojave%20Debug%20%28Build%29/ > builds/193 Thanks for letting me know! Tried to fix it with <https://trac.webkit.org/r236903>. Created attachment 351748 [details]
The rest
Committed attachment 351748 [details] as <https://trac.webkit.org/r236913>. |