Bug 190225

Summary: Web Inspector: merge ProbeManager into DebuggerManager
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, inspector-bugzilla-changes, joepeck, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from ews103 for mac-sierra
none
Archive of layout-test-results from ews104 for mac-sierra-wk2
none
Archive of layout-test-results from ews114 for mac-sierra
none
Patch none

Devin Rousso
Reported 2018-10-02 16:22:23 PDT
There's no reason to have them separate, especially since DebuggerManager controls most of ProbeManager's functionality.
Attachments
Patch (33.23 KB, patch)
2018-10-02 16:39 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (33.24 KB, patch)
2018-10-02 17:51 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews103 for mac-sierra (2.96 MB, application/zip)
2018-10-02 18:52 PDT, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews104 for mac-sierra-wk2 (3.44 MB, application/zip)
2018-10-02 19:36 PDT, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews114 for mac-sierra (3.10 MB, application/zip)
2018-10-02 19:57 PDT, EWS Watchlist 		no flags
Details
Patch (33.22 KB, patch)
2018-10-02 21:43 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2018-10-02 16:39:22 PDT
Created attachment 351453 [details] Patch
Joseph Pecoraro
Comment 2 2018-10-02 16:52:30 PDT
Comment on attachment 351453 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351453&action=review r- > Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js:1276 > + this._breakpointAdded(breakpoint); This appears to call _breakpointAdded which doesn't exist anymore... Given the subtlety in renaming and moving things this might need more work. It is unclear all of the changes that happened in this merge.
Devin Rousso
Comment 3 2018-10-02 17:49:05 PDT
Comment on attachment 351453 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351453&action=review >> Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js:1276 >> + this._breakpointAdded(breakpoint); > > This appears to call _breakpointAdded which doesn't exist anymore... Given the subtlety in renaming and moving things this might need more work. It is unclear all of the changes that happened in this merge. Most of the changes (outside of copypasta) are basic modernization (e.g. `var` to `let`). Functionality should be unchanged.
Devin Rousso
Comment 4 2018-10-02 17:51:52 PDT
Created attachment 351462 [details] Patch
EWS Watchlist
Comment 5 2018-10-02 18:52:16 PDT Comment hidden (obsolete)
EWS Watchlist
Comment 6 2018-10-02 18:52:17 PDT Comment hidden (obsolete)
EWS Watchlist
Comment 7 2018-10-02 19:35:59 PDT Comment hidden (obsolete)
EWS Watchlist
Comment 8 2018-10-02 19:36:01 PDT Comment hidden (obsolete)
EWS Watchlist
Comment 9 2018-10-02 19:57:30 PDT Comment hidden (obsolete)
EWS Watchlist
Comment 10 2018-10-02 19:57:32 PDT Comment hidden (obsolete)
Devin Rousso
Comment 11 2018-10-02 21:43:16 PDT
Created attachment 351477 [details] Patch Typo :(
Joseph Pecoraro
Comment 12 2018-10-04 12:47:30 PDT
Comment on attachment 351477 [details] Patch r=me
WebKit Commit Bot
Comment 13 2018-10-04 13:27:52 PDT
Comment on attachment 351477 [details] Patch Clearing flags on attachment: 351477 Committed r236845: <https://trac.webkit.org/changeset/236845>
WebKit Commit Bot
Comment 14 2018-10-04 13:27:54 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 15 2018-10-04 13:54:20 PDT
<rdar://problem/45020758>
Note You need to log in before you can comment on or make changes to this bug.