Summary: | radio / checkbox inputs should fire "click, input, change" events in order when clicked | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||
Component: | DOM | Assignee: | Chris Dumez <cdumez> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, cdumez, commit-queue, darin, ggaren, rniwa, sam, webkit-bug-importer, youennf | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 190252 | ||||||
Bug Blocks: | 190891 | ||||||
Attachments: |
|
Description
Chris Dumez
2018-10-02 15:42:05 PDT
Created attachment 351448 [details]
Patch
Comment on attachment 351448 [details] Patch Clearing flags on attachment: 351448 Committed r236779: <https://trac.webkit.org/changeset/236779> All reviewed patches have been landed. Closing bug. Comment on attachment 351448 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351448&action=review > Source/WebCore/html/BaseCheckableInputType.cpp:132 > + element()->setTextAsOfLastFormControlChangeEvent(String()); > + element()->dispatchInputEvent(); > + element()->dispatchFormControlChangeEvent(); Seems like there is a null check missing here. What guarantees that detachFromElement() won’t be called as a result of dispatching the input event? Comment on attachment 351448 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351448&action=review >> Source/WebCore/html/BaseCheckableInputType.cpp:132 >> + element()->dispatchFormControlChangeEvent(); > > Seems like there is a null check missing here. What guarantees that detachFromElement() won’t be called as a result of dispatching the input event? You are right. I will follow-up. |