Bug 190176

Summary:

REGRESSION: TestWebKitAPI.WKWebView.ProvisionalURLNotChange API test is failing

Product:

WebKit

Reporter:

Dawei Fenton (:realdawei) <realdawei>

Component:

Tools / Tests

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, cdumez, commit-queue, ggaren, lforschler, ryanhaddad, tsavell, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Dawei Fenton (:realdawei)

Reported 2018-10-01 16:46:20 PDT

API test TestWebKitAPI.WKWebView.ProvisionalURLNotChange is failing on Mojave (Release and Debug) sample output: https://build.webkit.org/builders/Apple%20Mojave%20Release%20WK2%20(Tests)/builds/59/steps/run-api-tests/logs/stdio TestWebKitAPI.WKWebView.ProvisionalURLNotChange _RegisterApplication(), FAILED TO establish the default connection to the WindowServer, _CGSDefaultConnection() is NULL. /Volumes/Data/slave/mojave-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProvisionalURLNotChange.mm:59 Expected equality of these values: [webView URL].absoluteString.UTF8String Which is: "http://www.webkit.org!/" "data:text/html,start" It has been failing since Mojave queues were added to build.webkit.org

Attachments
Patch (1.58 KB, patch) 2018-10-02 12:02 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2018-10-01 16:48:32 PDT

<rdar://problem/44925871>

Chris Dumez

Comment 2 2018-10-02 10:54:48 PDT

This test was introduced in http://trac.webkit.org/r184151. It seems we have regressed it and [webView URL].absoluteString.UTF8String can now return an invalid URL. It could also be that we recognize "http://www.webkit.org!/" as a valid URL now.

Chris Dumez

Comment 3 2018-10-02 11:52:23 PDT

It does not reproduce locally for me or Alex.

Chris Dumez

Comment 4 2018-10-02 11:57:46 PDT

"http://www.webkit.org!" is valid URL according to WebKit's URL parser.

Chris Dumez

Comment 5 2018-10-02 12:02:34 PDT

Created attachment 351426 [details] Patch

Alex Christensen

Comment 6 2018-10-02 12:34:24 PDT

Comment on attachment 351426 [details] Patch This is a speculative fix. r=me

WebKit Commit Bot

Comment 7 2018-10-02 13:44:37 PDT

Comment on attachment 351426 [details] Patch Clearing flags on attachment: 351426 Committed r236764: <https://trac.webkit.org/changeset/236764>

WebKit Commit Bot

Comment 8 2018-10-02 13:44:39 PDT

All reviewed patches have been landed. Closing bug.

Chris Dumez

Comment 9 2018-10-02 14:16:13 PDT

(In reply to Alex Christensen from comment #6) > Comment on attachment 351426 [details] > Patch > > This is a speculative fix. r=me David confirmed that this speculative fix made the test pass on the bot.

Note You need to log in before you can comment on or make changes to this bug.