Bug 190163 – Create a RELEASE_AND_RETURN macro for ExceptionScopes

• Component: New Bugs
• Status: RESOLVED FIXED

[Keith Miller]

Create a RELEASE_AND_RETURN macro for ExceptionScopes

[Keith Miller]

Created attachment 351300 [details]
Patch

[Mark Lam]

Comment on attachment 351300 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351300&action=review

r=me with unnecessary braces removed.

> Source/JavaScriptCore/dfg/DFGOperations.cpp:266
>      if (prototype.isObject()) {
> -        scope.release();
> -        return constructEmptyObject(exec, asObject(prototype));
> +        RELEASE_AND_RETURN(scope, constructEmptyObject(exec, asObject(prototype)));
>      }

Don't need braces anymore.  Ditto many places below.

> Source/JavaScriptCore/runtime/ExceptionScope.h:96
> +#define RELEASE_AND_RETURN(scope__, expression__) do { \

Pity that this name is so much more generic that RETURN_IF_EXCEPTION, but no one else has this idiom yet.  So, I'm ok going with this until there's a need to rename it.

[Keith Miller]

Comment on attachment 351300 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351300&action=review

>> Source/JavaScriptCore/dfg/DFGOperations.cpp:266
>>      }
> 
> Don't need braces anymore.  Ditto many places below.

Weird that the linter didn't catch that :(

>> Source/JavaScriptCore/runtime/ExceptionScope.h:96
>> +#define RELEASE_AND_RETURN(scope__, expression__) do { \
> 
> Pity that this name is so much more generic that RETURN_IF_EXCEPTION, but no one else has this idiom yet.  So, I'm ok going with this until there's a need to rename it.

How would you feel about RELEASE_SCOPE_AND_RETURN?

[Mark Lam]

(In reply to Keith Miller from comment #3)
> How would you feel about RELEASE_SCOPE_AND_RETURN?

RELEASE_SCOPE_AND_RETURN is slightly less generic but also more verbose.  I think we should just leave it as RELEASE_AND_RETURN for now.  Don't fix it if it ain't broke.

[Keith Miller]

Created attachment 351317 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 351317 [details]
Patch for landing

Clearing flags on attachment: 351317

Committed r236697: <https://trac.webkit.org/changeset/236697>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/44925105>