Bug 190154

Summary: Remove ParsedURLString
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, cdumez, don.olmstead, fujii.hironori, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch cdumez: review+

Alex Christensen
Reported 2018-10-01 13:56:22 PDT
Remove ParsedURLString
Attachments
Patch (66.17 KB, patch)
2018-10-01 14:03 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (66.13 KB, patch)
2018-10-01 14:28 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (66.13 KB, patch)
2018-10-01 14:45 PDT, Alex Christensen 		cdumez: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2018-10-01 14:03:57 PDT
Created attachment 351296 [details] Patch
Alex Christensen
Comment 2 2018-10-01 14:28:28 PDT
Created attachment 351299 [details] Patch
Alex Christensen
Comment 3 2018-10-01 14:45:46 PDT
Created attachment 351305 [details] Patch
Alex Christensen
Comment 4 2018-10-01 17:30:10 PDT
I removed all instances of ParsedURLString but WinCairo still wants it, which means WinCairo is using a stale header somewhere.
Fujii Hironori
Comment 5 2018-10-01 18:35:20 PDT
(In reply to Alex Christensen from comment #4) > I removed all instances of ParsedURLString but WinCairo still wants it, > which means WinCairo is using a stale header somewhere. This EWS failure seems a incremental build issue of Ninja. According to the build log, ResourceRequestBase.h is not copied to forwarding header dir.
Fujii Hironori
Comment 6 2018-10-01 20:03:11 PDT
(In reply to Fujii Hironori from comment #5) > This EWS failure seems a incremental build issue of Ninja. > According to the build log, ResourceRequestBase.h is not copied to > forwarding header dir. I'm going to look into it in Bug 190183. I've confirmed this incremental build issue can be recovered by doing the next incremental build. Feel feel to proceed.
Chris Dumez
Comment 7 2018-10-02 13:20:18 PDT
Comment on attachment 351305 [details] Patch r=me
Alex Christensen
Comment 8 2018-10-05 21:19:25 PDT
https://trac.webkit.org/changeset/236762/webkit
Radar WebKit Bug Importer
Comment 9 2018-10-05 21:20:23 PDT
<rdar://problem/45062990>
Note You need to log in before you can comment on or make changes to this bug.