Bug 190154

Summary: Remove ParsedURLString
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, cdumez, don.olmstead, Hironori.Fujii, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch cdumez: review+

Description Alex Christensen 2018-10-01 13:56:22 PDT
Remove ParsedURLString
Comment 1 Alex Christensen 2018-10-01 14:03:57 PDT
Created attachment 351296 [details]
Patch
Comment 2 Alex Christensen 2018-10-01 14:28:28 PDT
Created attachment 351299 [details]
Patch
Comment 3 Alex Christensen 2018-10-01 14:45:46 PDT
Created attachment 351305 [details]
Patch
Comment 4 Alex Christensen 2018-10-01 17:30:10 PDT
I removed all instances of ParsedURLString but WinCairo still wants it, which means WinCairo is using a stale header somewhere.
Comment 5 Fujii Hironori 2018-10-01 18:35:20 PDT
(In reply to Alex Christensen from comment #4)
> I removed all instances of ParsedURLString but WinCairo still wants it,
> which means WinCairo is using a stale header somewhere.

This EWS failure seems a incremental build issue of Ninja.
According to the build log, ResourceRequestBase.h is not copied to forwarding header dir.
Comment 6 Fujii Hironori 2018-10-01 20:03:11 PDT
(In reply to Fujii Hironori from comment #5)
> This EWS failure seems a incremental build issue of Ninja.
> According to the build log, ResourceRequestBase.h is not copied to
> forwarding header dir.

I'm going to look into it in Bug 190183.
I've confirmed this incremental build issue can be recovered by doing the next incremental build.
Feel feel to proceed.
Comment 7 Chris Dumez 2018-10-02 13:20:18 PDT
Comment on attachment 351305 [details]
Patch

r=me
Comment 8 Alex Christensen 2018-10-05 21:19:25 PDT
https://trac.webkit.org/changeset/236762/webkit
Comment 9 Radar WebKit Bug Importer 2018-10-05 21:20:23 PDT
<rdar://problem/45062990>