Bug 190151

Summary:

MessageEvent.ports should return the same object

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

DOM

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, cdumez, commit-queue, darin, dbates, esprehn+autocc, ews-watchlist, ggaren, kangil.han, kondapallykalyan, rniwa, sam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews102 for mac-sierra	none
Archive of layout-test-results from ews114 for mac-sierra	none
Patch	none

Chris Dumez

Reported 2018-10-01 12:26:58 PDT

MessageEvent.ports should return the same object it was initialized to instead of constructing a new JSValue every time.

Attachments
Patch (6.00 KB, patch) 2018-10-01 12:28 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-sierra (2.47 MB, application/zip) 2018-10-01 14:38 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews114 for mac-sierra (3.41 MB, application/zip) 2018-10-01 14:48 PDT, EWS Watchlist	no flags	Details
Patch (7.05 KB, patch) 2018-10-01 14:52 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2018-10-01 12:28:29 PDT

Created attachment 351284 [details] Patch

EWS Watchlist

Comment 2 2018-10-01 14:38:26 PDT

Comment on attachment 351284 [details] Patch Attachment 351284 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9415792 New failing tests: imported/w3c/web-platform-tests/html/webappapis/scripting/events/messageevent-constructor.https.html

EWS Watchlist

Comment 3 2018-10-01 14:38:28 PDT

Created attachment 351301 [details] Archive of layout-test-results from ews102 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 4 2018-10-01 14:47:59 PDT

Comment on attachment 351284 [details] Patch Attachment 351284 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9415152 New failing tests: imported/w3c/web-platform-tests/html/webappapis/scripting/events/messageevent-constructor.https.html

EWS Watchlist

Comment 5 2018-10-01 14:48:01 PDT

Created attachment 351306 [details] Archive of layout-test-results from ews114 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-sierra Platform: Mac OS X 10.12.6

Chris Dumez

Comment 6 2018-10-01 14:52:35 PDT

Created attachment 351309 [details] Patch

Chris Dumez

Comment 7 2018-10-02 12:22:55 PDT

ping review?

WebKit Commit Bot

Comment 8 2018-10-02 18:59:14 PDT

Comment on attachment 351309 [details] Patch Clearing flags on attachment: 351309 Committed r236784: <https://trac.webkit.org/changeset/236784>

WebKit Commit Bot

Comment 9 2018-10-02 18:59:16 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 10 2018-10-02 19:01:04 PDT

<rdar://problem/44961901>

Note You need to log in before you can comment on or make changes to this bug.